Fix Nova-net netowrk commands

In cleaning up functional tests for nova-net, I discovered some
problems in network create:
* --subnet option is required in network create command
* Switch API to use /os-networks rather than /os-tenant-networks as this
  is what we were actually using via novaclient
* Fix functional tests for nova-net
* Normalize some private function names in network/v2/network.py

Change-Id: I426b864406756d58d140575a3a45ee9aee67ce84

1 files changed, 18 insertions, 0 deletions

diff --git a/openstackclient/tests/unit/network/v2/test_network_compute.py b/openstackclient/tests/unit/network/v2/test_network_compute.py
index 25beb859..c649401c 100644
--- a/openstackclient/tests/unit/network/v2/test_network_compute.py
+++ b/openstackclient/tests/unit/network/v2/test_network_compute.py
@@ -132,6 +132,24 @@ class TestCreateNetworkCompute(TestNetworkCompute):
             verifylist,
         )
 
+    def test_network_create_missing_options(self, net_mock):
+        net_mock.return_value = self._network
+        arglist = [
+            self._network['label'],
+        ]
+        verifylist = [
+            ('name', self._network['label']),
+        ]
+
+        # Missing required args should raise exception here
+        self.assertRaises(
+            tests_utils.ParserException,
+            self.check_parser,
+            self.cmd,
+            arglist,
+            verifylist,
+        )
+
     def test_network_create_default_options(self, net_mock):
         net_mock.return_value = self._network
         arglist = [