summaryrefslogtreecommitdiff
path: root/openstackclient/tests/unit/network
diff options
context:
space:
mode:
authorStephen Finucane <sfinucan@redhat.com>2021-10-08 18:06:11 +0100
committerStephen Finucane <sfinucan@redhat.com>2021-10-21 17:14:45 +0100
commit30612bf62295720a21d39c4f589cfcefb7a86a2f (patch)
treea3133b6071a62e32dbb5c899f918cd2827ff208a /openstackclient/tests/unit/network
parenta797c9d2a351fd87d2f8075bbf7180fc6b202d92 (diff)
downloadpython-openstackclient-30612bf62295720a21d39c4f589cfcefb7a86a2f.tar.gz
Remove 'get_osc_show_columns_for_sdk_resource' duplicates
There were a number of 'get_osc_show_columns_for_sdk_resource' defined in-tree. However, osc-lib has provided this method for some time (since 2.2.0, June 2020 [1] - our minimum version is currently 2.3.0) so there's no need to provide our own copies. Remove them. [1] https://github.com/openstack/osc-lib/commit/29a0c5a5 Change-Id: I25695f4f9a379dd691b7eaa1e3247164668ae77e Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Diffstat (limited to 'openstackclient/tests/unit/network')
-rw-r--r--openstackclient/tests/unit/network/test_sdk_utils.py59
1 files changed, 0 insertions, 59 deletions
diff --git a/openstackclient/tests/unit/network/test_sdk_utils.py b/openstackclient/tests/unit/network/test_sdk_utils.py
deleted file mode 100644
index d1efa7e4..00000000
--- a/openstackclient/tests/unit/network/test_sdk_utils.py
+++ /dev/null
@@ -1,59 +0,0 @@
-# Licensed under the Apache License, Version 2.0 (the "License"); you may
-# not use this file except in compliance with the License. You may obtain
-# a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
-# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
-# License for the specific language governing permissions and limitations
-# under the License.
-
-from openstackclient.network import sdk_utils
-from openstackclient.tests.unit import utils as tests_utils
-
-
-class TestSDKUtils(tests_utils.TestCase):
-
- def setUp(self):
- super(TestSDKUtils, self).setUp()
-
- def _test_get_osc_show_columns_for_sdk_resource(
- self, sdk_resource, column_map,
- expected_display_columns, expected_attr_columns):
- display_columns, attr_columns = \
- sdk_utils.get_osc_show_columns_for_sdk_resource(
- sdk_resource, column_map)
- self.assertEqual(expected_display_columns, display_columns)
- self.assertEqual(expected_attr_columns, attr_columns)
-
- def test_get_osc_show_columns_for_sdk_resource_empty(self):
- self._test_get_osc_show_columns_for_sdk_resource(
- {}, {}, tuple(), tuple())
-
- def test_get_osc_show_columns_for_sdk_resource_empty_map(self):
- self._test_get_osc_show_columns_for_sdk_resource(
- {'foo': 'foo1'}, {},
- ('foo',), ('foo',))
-
- def test_get_osc_show_columns_for_sdk_resource_empty_data(self):
- self._test_get_osc_show_columns_for_sdk_resource(
- {}, {'foo': 'foo_map'},
- ('foo_map',), ('foo_map',))
-
- def test_get_osc_show_columns_for_sdk_resource_map(self):
- self._test_get_osc_show_columns_for_sdk_resource(
- {'foo': 'foo1'}, {'foo': 'foo_map'},
- ('foo_map',), ('foo',))
-
- def test_get_osc_show_columns_for_sdk_resource_map_dup(self):
- self._test_get_osc_show_columns_for_sdk_resource(
- {'foo': 'foo1', 'foo_map': 'foo1'}, {'foo': 'foo_map'},
- ('foo_map',), ('foo',))
-
- def test_get_osc_show_columns_for_sdk_resource_map_full(self):
- self._test_get_osc_show_columns_for_sdk_resource(
- {'foo': 'foo1', 'bar': 'bar1'},
- {'foo': 'foo_map', 'new': 'bar'},
- ('bar', 'foo_map'), ('bar', 'foo'))