summaryrefslogtreecommitdiff
path: root/openstackclient/tests/unit/network
diff options
context:
space:
mode:
authorAkihiro Motoki <amotoki@gmail.com>2017-07-15 16:58:08 +0000
committerAkihiro Motoki <amotoki@gmail.com>2017-08-17 06:55:00 +0000
commitf3bbf52b3c7e731796aaf38294d08109859babe5 (patch)
treea73c02ce01812683f538a084c2cfeb486229a9d2 /openstackclient/tests/unit/network
parent53bea90a75774cb7468884da43b55381b491dc46 (diff)
downloadpython-openstackclient-f3bbf52b3c7e731796aaf38294d08109859babe5.tar.gz
Use flake8-import-order plugin
In reviews we usually check import grouping but it is boring. By using flake8-import-order plugin, we can avoid this. It enforces loose checking so it sounds good to use it. This flake8 plugin is already used in tempest. Note that flake8-import-order version is pinned to avoid unexpected breakage of pep8 job. Setup for unit tests of hacking rules is tweaked to disable flake8-import-order checks. This extension assumes an actual file exists and causes hacking rule unit tests. Change-Id: I12b596820727aeeb379bee16c2bc993dee9eb637
Diffstat (limited to 'openstackclient/tests/unit/network')
-rw-r--r--openstackclient/tests/unit/network/test_common.py1
-rw-r--r--openstackclient/tests/unit/network/v2/fakes.py3
-rw-r--r--openstackclient/tests/unit/network/v2/test_network.py4
-rw-r--r--openstackclient/tests/unit/network/v2/test_port.py2
-rw-r--r--openstackclient/tests/unit/network/v2/test_subnet_pool.py2
5 files changed, 7 insertions, 5 deletions
diff --git a/openstackclient/tests/unit/network/test_common.py b/openstackclient/tests/unit/network/test_common.py
index 4b9a754b..c8dce0af 100644
--- a/openstackclient/tests/unit/network/test_common.py
+++ b/openstackclient/tests/unit/network/test_common.py
@@ -12,6 +12,7 @@
#
import argparse
+
import mock
import openstack
diff --git a/openstackclient/tests/unit/network/v2/fakes.py b/openstackclient/tests/unit/network/v2/fakes.py
index eadab584..bdc1c1fb 100644
--- a/openstackclient/tests/unit/network/v2/fakes.py
+++ b/openstackclient/tests/unit/network/v2/fakes.py
@@ -13,11 +13,12 @@
import argparse
import copy
-import mock
from random import choice
from random import randint
import uuid
+import mock
+
from openstackclient.tests.unit import fakes
from openstackclient.tests.unit.identity.v3 import fakes as identity_fakes_v3
from openstackclient.tests.unit import utils
diff --git a/openstackclient/tests/unit/network/v2/test_network.py b/openstackclient/tests/unit/network/v2/test_network.py
index 7b20c793..357088f3 100644
--- a/openstackclient/tests/unit/network/v2/test_network.py
+++ b/openstackclient/tests/unit/network/v2/test_network.py
@@ -11,10 +11,10 @@
# under the License.
#
-import mock
-from mock import call
import random
+import mock
+from mock import call
from osc_lib import exceptions
from osc_lib import utils
diff --git a/openstackclient/tests/unit/network/v2/test_port.py b/openstackclient/tests/unit/network/v2/test_port.py
index 97be5afd..45e1045d 100644
--- a/openstackclient/tests/unit/network/v2/test_port.py
+++ b/openstackclient/tests/unit/network/v2/test_port.py
@@ -12,8 +12,8 @@
#
import argparse
-import mock
+import mock
from mock import call
from osc_lib import exceptions
from osc_lib import utils
diff --git a/openstackclient/tests/unit/network/v2/test_subnet_pool.py b/openstackclient/tests/unit/network/v2/test_subnet_pool.py
index 139fddf8..81f0278f 100644
--- a/openstackclient/tests/unit/network/v2/test_subnet_pool.py
+++ b/openstackclient/tests/unit/network/v2/test_subnet_pool.py
@@ -12,9 +12,9 @@
#
import argparse
+
import mock
from mock import call
-
from osc_lib import exceptions
from osc_lib import utils