Add "consistency group delete" command

Add "consistency group delete" command in volume v2 (v2 only).

Change-Id: Ieebc2417df0d45a578d5617bad245d7863f09190
Implements: bp cinder-command-support
Partial-Bug: #1613964

2 files changed, 125 insertions, 0 deletions

diff --git a/openstackclient/tests/unit/volume/v2/fakes.py b/openstackclient/tests/unit/volume/v2/fakes.py
index 41d8e794..3137bfb0 100644
--- a/openstackclient/tests/unit/volume/v2/fakes.py
+++ b/openstackclient/tests/unit/volume/v2/fakes.py
@@ -546,6 +546,30 @@ class FakeConsistencyGroup(object):
 
         return consistency_groups
 
+    @staticmethod
+    def get_consistency_groups(consistency_groups=None, count=2):
+        """Note:
+
+        Get an iterable MagicMock object with a list of faked
+        consistency_groups.
+
+        If consistency_groups list is provided, then initialize
+        the Mock object with the list. Otherwise create one.
+
+        :param List consistency_groups:
+            A list of FakeResource objects faking consistency_groups
+        :param Integer count:
+            The number of consistency_groups to be faked
+        :return
+            An iterable Mock object with side_effect set to a list of faked
+            consistency_groups
+        """
+        if consistency_groups is None:
+            consistency_groups = (FakeConsistencyGroup.
+                                  create_consistency_groups(count))
+
+        return mock.Mock(side_effect=consistency_groups)
+
 
 class FakeConsistencyGroupSnapshot(object):
     """Fake one or more consistency group snapshot."""
diff --git a/openstackclient/tests/unit/volume/v2/test_consistency_group.py b/openstackclient/tests/unit/volume/v2/test_consistency_group.py
index e0056421..835d9960 100644
--- a/openstackclient/tests/unit/volume/v2/test_consistency_group.py
+++ b/openstackclient/tests/unit/volume/v2/test_consistency_group.py
@@ -12,6 +12,10 @@
 #   under the License.
 #
 
+import mock
+from mock import call
+
+from osc_lib import exceptions
 from osc_lib import utils
 
 from openstackclient.tests.unit.volume.v2 import fakes as volume_fakes
@@ -161,6 +165,103 @@ class TestConsistencyGroupCreate(TestConsistencyGroup):
         self.assertEqual(self.data, data)
 
 
+class TestConsistencyGroupDelete(TestConsistencyGroup):
+
+    consistency_groups =\
+        volume_fakes.FakeConsistencyGroup.create_consistency_groups(count=2)
+
+    def setUp(self):
+        super(TestConsistencyGroupDelete, self).setUp()
+
+        self.consistencygroups_mock.get = volume_fakes.FakeConsistencyGroup.\
+            get_consistency_groups(self.consistency_groups)
+        self.consistencygroups_mock.delete.return_value = None
+
+        # Get the command object to mock
+        self.cmd = consistency_group.DeleteConsistencyGroup(self.app, None)
+
+    def test_consistency_group_delete(self):
+        arglist = [
+            self.consistency_groups[0].id
+        ]
+        verifylist = [
+            ("consistency_groups", [self.consistency_groups[0].id])
+        ]
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+
+        result = self.cmd.take_action(parsed_args)
+
+        self.consistencygroups_mock.delete.assert_called_with(
+            self.consistency_groups[0].id, False)
+        self.assertIsNone(result)
+
+    def test_consistency_group_delete_with_force(self):
+        arglist = [
+            '--force',
+            self.consistency_groups[0].id,
+        ]
+        verifylist = [
+            ('force', True),
+            ("consistency_groups", [self.consistency_groups[0].id])
+        ]
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+
+        result = self.cmd.take_action(parsed_args)
+
+        self.consistencygroups_mock.delete.assert_called_with(
+            self.consistency_groups[0].id, True)
+        self.assertIsNone(result)
+
+    def test_delete_multiple_consistency_groups(self):
+        arglist = []
+        for b in self.consistency_groups:
+            arglist.append(b.id)
+        verifylist = [
+            ('consistency_groups', arglist),
+        ]
+
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+        result = self.cmd.take_action(parsed_args)
+
+        calls = []
+        for b in self.consistency_groups:
+            calls.append(call(b.id, False))
+        self.consistencygroups_mock.delete.assert_has_calls(calls)
+        self.assertIsNone(result)
+
+    def test_delete_multiple_consistency_groups_with_exception(self):
+        arglist = [
+            self.consistency_groups[0].id,
+            'unexist_consistency_group',
+        ]
+        verifylist = [
+            ('consistency_groups', arglist),
+        ]
+
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+
+        find_mock_result = [self.consistency_groups[0],
+                            exceptions.CommandError]
+        with mock.patch.object(utils, 'find_resource',
+                               side_effect=find_mock_result) as find_mock:
+            try:
+                self.cmd.take_action(parsed_args)
+                self.fail('CommandError should be raised.')
+            except exceptions.CommandError as e:
+                self.assertEqual('1 of 2 consistency groups failed to delete.',
+                                 str(e))
+
+            find_mock.assert_any_call(self.consistencygroups_mock,
+                                      self.consistency_groups[0].id)
+            find_mock.assert_any_call(self.consistencygroups_mock,
+                                      'unexist_consistency_group')
+
+            self.assertEqual(2, find_mock.call_count)
+            self.consistencygroups_mock.delete.assert_called_once_with(
+                self.consistency_groups[0].id, False
+            )
+
+
 class TestConsistencyGroupList(TestConsistencyGroup):
 
     consistency_groups = (