Implement "volume transfer request show/accept" command

Add "volume transfer request show" and
"volume transfer accept" commands in
volume v1 and v2. Also add the unit tests,
docs, release note and functional tests

Implements: bp cinder-command-support
Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>

Change-Id: I5787fc486b3401307125caa316f517b9c96a95a5

4 files changed, 194 insertions, 6 deletions

diff --git a/openstackclient/tests/unit/volume/v1/fakes.py b/openstackclient/tests/unit/volume/v1/fakes.py
index 33374499..ef52e4b0 100644
--- a/openstackclient/tests/unit/volume/v1/fakes.py
+++ b/openstackclient/tests/unit/volume/v1/fakes.py
@@ -146,8 +146,6 @@ class FakeTransfer(object):
         """
         # Set default attribute
         transfer_info = {
-            'auth_key': 'key-' + uuid.uuid4().hex,
-            'created_at': 'time-' + uuid.uuid4().hex,
             'volume_id': 'volume-id-' + uuid.uuid4().hex,
             'name': 'fake_transfer_name',
             'id': 'id-' + uuid.uuid4().hex,
diff --git a/openstackclient/tests/unit/volume/v1/test_transfer_request.py b/openstackclient/tests/unit/volume/v1/test_transfer_request.py
index e89c5056..b3788d6e 100644
--- a/openstackclient/tests/unit/volume/v1/test_transfer_request.py
+++ b/openstackclient/tests/unit/volume/v1/test_transfer_request.py
@@ -36,6 +36,53 @@ class TestTransfer(transfer_fakes.TestVolumev1):
         self.volumes_mock.reset_mock()
 
 
+class TestTransferAccept(TestTransfer):
+
+    columns = (
+        'id',
+        'name',
+        'volume_id',
+    )
+
+    def setUp(self):
+        super(TestTransferAccept, self).setUp()
+
+        self.volume_transfer = (
+            transfer_fakes.FakeTransfer.create_one_transfer())
+        self.data = (
+            self.volume_transfer.id,
+            self.volume_transfer.name,
+            self.volume_transfer.volume_id,
+        )
+
+        self.transfer_mock.get.return_value = self.volume_transfer
+        self.transfer_mock.accept.return_value = self.volume_transfer
+
+        # Get the command object to test
+        self.cmd = volume_transfer_request.AcceptTransferRequest(
+            self.app, None)
+
+    def test_transfer_accept(self):
+        arglist = [
+            self.volume_transfer.id,
+            'auth_key',
+        ]
+        verifylist = [
+            ('transfer_request', self.volume_transfer.id),
+            ('auth_key', 'auth_key'),
+        ]
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+
+        columns, data = self.cmd.take_action(parsed_args)
+
+        self.transfer_mock.get.assert_called_once_with(
+            self.volume_transfer.id)
+        self.transfer_mock.accept.assert_called_once_with(
+            self.volume_transfer.id, 'auth_key')
+        self.assertEqual(self.columns, columns)
+        self.assertEqual(self.data, data)
+
+
 class TestTransferCreate(TestTransfer):
 
     volume = transfer_fakes.FakeVolume.create_one_volume()
@@ -52,7 +99,10 @@ class TestTransferCreate(TestTransfer):
         super(TestTransferCreate, self).setUp()
 
         self.volume_transfer = transfer_fakes.FakeTransfer.create_one_transfer(
-            attrs={'volume_id': self.volume.id})
+            attrs={'volume_id': self.volume.id,
+                   'auth_key': 'key',
+                   'created_at': 'time'}
+        )
         self.data = (
             self.volume_transfer.auth_key,
             self.volume_transfer.created_at,
@@ -266,3 +316,49 @@ class TestTransferList(TestTransfer):
             detailed=True,
             search_opts={'all_tenants': 1}
         )
+
+
+class TestTransferShow(TestTransfer):
+
+    columns = (
+        'created_at',
+        'id',
+        'name',
+        'volume_id',
+    )
+
+    def setUp(self):
+        super(TestTransferShow, self).setUp()
+
+        self.volume_transfer = (
+            transfer_fakes.FakeTransfer.create_one_transfer(
+                attrs={'created_at': 'time'})
+        )
+        self.data = (
+            self.volume_transfer.created_at,
+            self.volume_transfer.id,
+            self.volume_transfer.name,
+            self.volume_transfer.volume_id,
+        )
+
+        self.transfer_mock.get.return_value = self.volume_transfer
+
+        # Get the command object to test
+        self.cmd = volume_transfer_request.ShowTransferRequest(
+            self.app, None)
+
+    def test_transfer_show(self):
+        arglist = [
+            self.volume_transfer.id,
+        ]
+        verifylist = [
+            ('transfer_request', self.volume_transfer.id),
+        ]
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+
+        columns, data = self.cmd.take_action(parsed_args)
+
+        self.transfer_mock.get.assert_called_once_with(
+            self.volume_transfer.id)
+        self.assertEqual(self.columns, columns)
+        self.assertEqual(self.data, data)
diff --git a/openstackclient/tests/unit/volume/v2/fakes.py b/openstackclient/tests/unit/volume/v2/fakes.py
index 8d7ac831..2aeea60a 100644
--- a/openstackclient/tests/unit/volume/v2/fakes.py
+++ b/openstackclient/tests/unit/volume/v2/fakes.py
@@ -52,8 +52,6 @@ class FakeTransfer(object):
         """
         # Set default attribute
         transfer_info = {
-            'auth_key': 'key-' + uuid.uuid4().hex,
-            'created_at': 'time-' + uuid.uuid4().hex,
             'volume_id': 'volume-id-' + uuid.uuid4().hex,
             'name': 'fake_transfer_name',
             'id': 'id-' + uuid.uuid4().hex,
diff --git a/openstackclient/tests/unit/volume/v2/test_transfer_request.py b/openstackclient/tests/unit/volume/v2/test_transfer_request.py
index b4f89089..8cd6534b 100644
--- a/openstackclient/tests/unit/volume/v2/test_transfer_request.py
+++ b/openstackclient/tests/unit/volume/v2/test_transfer_request.py
@@ -36,6 +36,53 @@ class TestTransfer(transfer_fakes.TestVolume):
         self.volumes_mock.reset_mock()
 
 
+class TestTransferAccept(TestTransfer):
+
+    columns = (
+        'id',
+        'name',
+        'volume_id',
+    )
+
+    def setUp(self):
+        super(TestTransferAccept, self).setUp()
+
+        self.volume_transfer = (
+            transfer_fakes.FakeTransfer.create_one_transfer())
+        self.data = (
+            self.volume_transfer.id,
+            self.volume_transfer.name,
+            self.volume_transfer.volume_id,
+        )
+
+        self.transfer_mock.get.return_value = self.volume_transfer
+        self.transfer_mock.accept.return_value = self.volume_transfer
+
+        # Get the command object to test
+        self.cmd = volume_transfer_request.AcceptTransferRequest(
+            self.app, None)
+
+    def test_transfer_accept(self):
+        arglist = [
+            self.volume_transfer.id,
+            'auth_key',
+        ]
+        verifylist = [
+            ('transfer_request', self.volume_transfer.id),
+            ('auth_key', 'auth_key'),
+        ]
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+
+        columns, data = self.cmd.take_action(parsed_args)
+
+        self.transfer_mock.get.assert_called_once_with(
+            self.volume_transfer.id)
+        self.transfer_mock.accept.assert_called_once_with(
+            self.volume_transfer.id, 'auth_key')
+        self.assertEqual(self.columns, columns)
+        self.assertEqual(self.data, data)
+
+
 class TestTransferCreate(TestTransfer):
 
     volume = transfer_fakes.FakeVolume.create_one_volume()
@@ -52,7 +99,10 @@ class TestTransferCreate(TestTransfer):
         super(TestTransferCreate, self).setUp()
 
         self.volume_transfer = transfer_fakes.FakeTransfer.create_one_transfer(
-            attrs={'volume_id': self.volume.id})
+            attrs={'volume_id': self.volume.id,
+                   'auth_key': 'key',
+                   'created_at': 'time'}
+        )
         self.data = (
             self.volume_transfer.auth_key,
             self.volume_transfer.created_at,
@@ -266,3 +316,49 @@ class TestTransferList(TestTransfer):
             detailed=True,
             search_opts={'all_tenants': 1}
         )
+
+
+class TestTransferShow(TestTransfer):
+
+    columns = (
+        'created_at',
+        'id',
+        'name',
+        'volume_id',
+    )
+
+    def setUp(self):
+        super(TestTransferShow, self).setUp()
+
+        self.volume_transfer = (
+            transfer_fakes.FakeTransfer.create_one_transfer(
+                attrs={'created_at': 'time'})
+        )
+        self.data = (
+            self.volume_transfer.created_at,
+            self.volume_transfer.id,
+            self.volume_transfer.name,
+            self.volume_transfer.volume_id,
+        )
+
+        self.transfer_mock.get.return_value = self.volume_transfer
+
+        # Get the command object to test
+        self.cmd = volume_transfer_request.ShowTransferRequest(
+            self.app, None)
+
+    def test_transfer_show(self):
+        arglist = [
+            self.volume_transfer.id,
+        ]
+        verifylist = [
+            ('transfer_request', self.volume_transfer.id),
+        ]
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+
+        columns, data = self.cmd.take_action(parsed_args)
+
+        self.transfer_mock.get.assert_called_once_with(
+            self.volume_transfer.id)
+        self.assertEqual(self.columns, columns)
+        self.assertEqual(self.data, data)