diff options
| author | Dean Troyer <dtroyer@gmail.com> | 2014-10-13 16:30:38 -0500 |
|---|---|---|
| committer | Dean Troyer <dtroyer@gmail.com> | 2014-10-14 15:45:20 -0500 |
| commit | 89217a6557e16872ac1af0e305ac09886a9e1255 (patch) | |
| tree | 359578b30ff96cf981bae1be8bd38c800988567f /openstackclient/tests/utils.py | |
| parent | 36212c43d880d0eaeb3df271cccb314802bf3372 (diff) | |
| download | python-openstackclient-89217a6557e16872ac1af0e305ac09886a9e1255.tar.gz | |
Close files on server create, add tests
The files opened for the --files and --user-data options were never
closed, potentially leaking memory in a long-running client. Close
them if they are file objects.
Add a couple of basic tests for server create.
Change-Id: I1658b0caa2d6af17308149cb52196ee28266ddf2
Diffstat (limited to 'openstackclient/tests/utils.py')
| -rw-r--r-- | openstackclient/tests/utils.py | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/openstackclient/tests/utils.py b/openstackclient/tests/utils.py index 38d47250..25f98525 100644 --- a/openstackclient/tests/utils.py +++ b/openstackclient/tests/utils.py @@ -23,6 +23,10 @@ import testtools from openstackclient.tests import fakes +class ParserException(Exception): + pass + + class TestCase(testtools.TestCase): def setUp(self): testtools.TestCase.setUp(self) @@ -84,7 +88,7 @@ class TestCommand(TestCase): try: parsed_args = cmd_parser.parse_args(args) except SystemExit: - raise Exception("Argument parse failed") + raise ParserException("Argument parse failed") for av in verify_args: attr, value = av if attr: |