diff options
| author | Huanxuan Ao <huanxuan.ao@easystack.cn> | 2016-08-19 21:56:24 +0800 |
|---|---|---|
| committer | Huanxuan Ao <huanxuan.ao@easystack.cn> | 2016-08-23 10:31:24 +0800 |
| commit | 8f07fec3f2ccf510255f1ff2e4dab233be60d0f9 (patch) | |
| tree | 6060dd6bdafcb80bbe770ac00e5738ebafb2a6f1 /openstackclient/tests/volume/v1/fakes.py | |
| parent | 684412ca4cc0abad2c2a800d8247d12992b994e5 (diff) | |
| download | python-openstackclient-8f07fec3f2ccf510255f1ff2e4dab233be60d0f9.tar.gz | |
Clean up FakeClient classes in volume fakes
Put FakeTransferClient and FakeServiceClient classes
into FakeVolumeClient class, I think we need not to
create FakeClient classes for every objects, we can use
only FakeVolumeClient for all volume objects. This can
reduce repetition, unified codes and make codes look
cleaner and easier.
Change-Id: I2729ef0e80166f4d49ccd9a48b653e2f215e3bfe
Diffstat (limited to 'openstackclient/tests/volume/v1/fakes.py')
| -rw-r--r-- | openstackclient/tests/volume/v1/fakes.py | 39 |
1 files changed, 2 insertions, 37 deletions
diff --git a/openstackclient/tests/volume/v1/fakes.py b/openstackclient/tests/volume/v1/fakes.py index 2584d4b1..b96f925d 100644 --- a/openstackclient/tests/volume/v1/fakes.py +++ b/openstackclient/tests/volume/v1/fakes.py @@ -129,25 +129,6 @@ QOS_WITH_ASSOCIATIONS = { } -class FakeTransferClient(object): - - def __init__(self, **kwargs): - - self.transfers = mock.Mock() - self.transfers.resource_class = fakes.FakeResource(None, {}) - - -class TestTransfer(utils.TestCommand): - - def setUp(self): - super(TestTransfer, self).setUp() - - self.app.client_manager.volume = FakeTransferClient( - endpoint=fakes.AUTH_URL, - token=fakes.AUTH_TOKEN - ) - - class FakeTransfer(object): """Fake one or more Transfer.""" @@ -180,24 +161,6 @@ class FakeTransfer(object): return transfer -class FakeServiceClient(object): - - def __init__(self, **kwargs): - self.services = mock.Mock() - self.services.resource_class = fakes.FakeResource(None, {}) - - -class TestService(utils.TestCommand): - - def setUp(self): - super(TestService, self).setUp() - - self.app.client_manager.volume = FakeServiceClient( - endpoint=fakes.AUTH_URL, - token=fakes.AUTH_TOKEN - ) - - class FakeService(object): """Fake one or more Services.""" @@ -290,6 +253,8 @@ class FakeVolumev1Client(object): self.qos_specs.resource_class = fakes.FakeResource(None, {}) self.volume_types = mock.Mock() self.volume_types.resource_class = fakes.FakeResource(None, {}) + self.transfers = mock.Mock() + self.transfers.resource_class = fakes.FakeResource(None, {}) self.auth_token = kwargs['token'] self.management_url = kwargs['endpoint'] |
