diff options
| author | SaiKiran <saikiranveeravarapu@gmail.com> | 2016-01-12 20:39:02 +0530 |
|---|---|---|
| committer | SaiKiran <saikiranveeravarapu@gmail.com> | 2016-01-20 10:49:43 +0530 |
| commit | 604d8589ee0634af6f3f44c8579ff7ddaceb407d (patch) | |
| tree | 5a1667199b76bc52ecec333739bd7a524c903739 /openstackclient/tests/volume/v2/test_snapshot.py | |
| parent | 030aee6fbcca6be97dd898e8c1b4c05021832bbd (diff) | |
| download | python-openstackclient-604d8589ee0634af6f3f44c8579ff7ddaceb407d.tar.gz | |
Refactor: Abstract columns and datalist out in volume test cases
columns and datalist has been set in each test case in volume,
which is not necessary. This patch abstract it out and remove
all redundant code.
Change-Id: I3a09d5d2db86da986bdcfbf2310978ced181017d
Diffstat (limited to 'openstackclient/tests/volume/v2/test_snapshot.py')
| -rw-r--r-- | openstackclient/tests/volume/v2/test_snapshot.py | 30 |
1 files changed, 17 insertions, 13 deletions
diff --git a/openstackclient/tests/volume/v2/test_snapshot.py b/openstackclient/tests/volume/v2/test_snapshot.py index 3b30d4ef..1c1dd437 100644 --- a/openstackclient/tests/volume/v2/test_snapshot.py +++ b/openstackclient/tests/volume/v2/test_snapshot.py @@ -202,6 +202,15 @@ class TestSnapshotUnset(TestSnapshot): class TestSnapshotList(TestSnapshot): + + columns = [ + "ID", + "Name", + "Description", + "Status", + "Size" + ] + def setUp(self): super(TestSnapshotList, self).setUp() @@ -231,8 +240,7 @@ class TestSnapshotList(TestSnapshot): parsed_args = self.check_parser(self.cmd, arglist, verifylist) columns, data = self.cmd.take_action(parsed_args) - collist = ["ID", "Name", "Description", "Status", "Size"] - self.assertEqual(collist, columns) + self.assertEqual(self.columns, columns) datalist = (( volume_fakes.snapshot_id, volume_fakes.snapshot_name, @@ -249,9 +257,12 @@ class TestSnapshotList(TestSnapshot): columns, data = self.cmd.take_action(parsed_args) - collist = ["ID", "Name", "Description", "Status", "Size", "Created At", - "Volume", "Properties"] - self.assertEqual(collist, columns) + columns = self.columns + [ + "Created At", + "Volume", + "Properties" + ] + self.assertEqual(columns, columns) datalist = (( volume_fakes.snapshot_id, @@ -277,14 +288,7 @@ class TestSnapshotList(TestSnapshot): columns, data = self.cmd.take_action(parsed_args) - collist = [ - "ID", - "Name", - "Description", - "Status", - "Size" - ] - self.assertEqual(collist, columns) + self.assertEqual(self.columns, columns) datalist = (( volume_fakes.snapshot_id, |