diff options
| author | Bin Zhou <zhou.bin9@zte.com.cn> | 2016-09-02 12:05:58 +0800 |
|---|---|---|
| committer | Bin Zhou <zhou.bin9@zte.com.cn> | 2016-09-02 12:48:41 +0800 |
| commit | 1626b63f5698918ac73ec407b1922fc006b0db66 (patch) | |
| tree | 1f36eee7ad88e3f93492600717ebad2e3d237aea /openstackclient/tests | |
| parent | 45d3e67b98d59016d9f3ce66d2c8519d1cdbe7b7 (diff) | |
| download | python-openstackclient-1626b63f5698918ac73ec407b1922fc006b0db66.tar.gz | |
Use assertIn(A, B) instead of assertTrue(A in B )
Developers should use assertIn(A, B) instead of assertTrue(A in B ).
TrivialFix
Change-Id: I0d7c542272315590536c427a8865e49660361e55
Diffstat (limited to 'openstackclient/tests')
| -rw-r--r-- | openstackclient/tests/common/test_module.py | 12 | ||||
| -rw-r--r-- | openstackclient/tests/image/v2/test_image.py | 4 |
2 files changed, 8 insertions, 8 deletions
diff --git a/openstackclient/tests/common/test_module.py b/openstackclient/tests/common/test_module.py index 7d08dae7..8d5bb5f1 100644 --- a/openstackclient/tests/common/test_module.py +++ b/openstackclient/tests/common/test_module.py @@ -106,8 +106,8 @@ class TestModuleList(utils.TestCommand): columns, data = self.cmd.take_action(parsed_args) # Additional modules may be present, just check our additions - self.assertTrue(module_name_1 in columns) - self.assertTrue(module_version_1 in data) + self.assertIn(module_name_1, columns) + self.assertIn(module_version_1, data) def test_module_list_all(self): arglist = [ @@ -124,7 +124,7 @@ class TestModuleList(utils.TestCommand): columns, data = self.cmd.take_action(parsed_args) # Additional modules may be present, just check our additions - self.assertTrue(module_name_1 in columns) - self.assertTrue(module_name_2 in columns) - self.assertTrue(module_version_1 in data) - self.assertTrue(module_version_2 in data) + self.assertIn(module_name_1, columns) + self.assertIn(module_name_2, columns) + self.assertIn(module_version_1, data) + self.assertIn(module_version_2, data) diff --git a/openstackclient/tests/image/v2/test_image.py b/openstackclient/tests/image/v2/test_image.py index 2b116b4e..830590c9 100644 --- a/openstackclient/tests/image/v2/test_image.py +++ b/openstackclient/tests/image/v2/test_image.py @@ -1128,7 +1128,7 @@ class TestImageSet(TestImage): # ImageManager.update(image, **kwargs) a, k = self.images_mock.update.call_args self.assertEqual(image_fakes.image_id, a[0]) - self.assertTrue('tags' in k) + self.assertIn('tags', k) self.assertEqual(set(kwargs['tags']), set(k['tags'])) self.assertIsNone(result) @@ -1154,7 +1154,7 @@ class TestImageSet(TestImage): # ImageManager.update(image, **kwargs) a, k = self.images_mock.update.call_args self.assertEqual(image_fakes.image_id, a[0]) - self.assertTrue('tags' in k) + self.assertIn('tags', k) self.assertEqual(set(kwargs['tags']), set(k['tags'])) self.assertIsNone(result) |