summaryrefslogtreecommitdiff
path: root/openstackclient/tests
diff options
context:
space:
mode:
authorStephen Finucane <sfinucan@redhat.com>2020-11-09 14:53:57 +0000
committerStephen Finucane <sfinucan@redhat.com>2020-11-09 15:05:54 +0000
commit1a5dd4af5bf7fdc1b903b300b917f302ba75a1bc (patch)
treea7e92acc3725d69d72584c502539bf4c0624c376 /openstackclient/tests
parentcb6659d7cd28f9c9c6481c9222ff6d3a5308410a (diff)
downloadpython-openstackclient-1a5dd4af5bf7fdc1b903b300b917f302ba75a1bc.tar.gz
Resolve issues with 'server migration list'
The 'os-migrations' API accepts 'instance_uuid' and 'migration_type' query string parameters, not 'server' and 'type'. For the former, as the name would suggest, the value should be a server UUID, not a name. In addition, this is a list command and therefore should subclass the 'Lister' base class. Change-Id: I736f5575156fc04d7ada7783a1865ab3b438396f Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Diffstat (limited to 'openstackclient/tests')
-rw-r--r--openstackclient/tests/unit/compute/v2/test_server.py12
1 files changed, 3 insertions, 9 deletions
diff --git a/openstackclient/tests/unit/compute/v2/test_server.py b/openstackclient/tests/unit/compute/v2/test_server.py
index 15cdbf16..d095f0cb 100644
--- a/openstackclient/tests/unit/compute/v2/test_server.py
+++ b/openstackclient/tests/unit/compute/v2/test_server.py
@@ -4079,7 +4079,6 @@ class TestListMigration(TestServer):
kwargs = {
'status': None,
'host': None,
- 'server': None,
}
self.migrations_mock.list.assert_called_with(**kwargs)
@@ -4106,10 +4105,11 @@ class TestListMigration(TestServer):
kwargs = {
'status': 'migrating',
'host': 'host1',
- 'server': 'server1',
- 'type': 'migration',
+ 'instance_uuid': self.server.id,
+ 'migration_type': 'migration',
}
+ self.servers_mock.get.assert_called_with('server1')
self.migrations_mock.list.assert_called_with(**kwargs)
self.assertEqual(self.MIGRATION_COLUMNS, columns)
@@ -4145,7 +4145,6 @@ class TestListMigrationV223(TestListMigration):
kwargs = {
'status': 'migrating',
'host': None,
- 'server': None,
}
self.migrations_mock.list.assert_called_with(**kwargs)
@@ -4194,7 +4193,6 @@ class TestListMigrationV259(TestListMigration):
'limit': 1,
'marker': 'test_kp',
'host': None,
- 'server': None,
'changes_since': '2019-08-09T08:03:25Z',
}
@@ -4303,7 +4301,6 @@ class TestListMigrationV266(TestListMigration):
'limit': 1,
'marker': 'test_kp',
'host': None,
- 'server': None,
'changes_since': '2019-08-07T08:03:25Z',
'changes_before': '2019-08-09T08:03:25Z',
}
@@ -4375,7 +4372,6 @@ class TestListMigrationV280(TestListMigration):
'limit': 1,
'marker': 'test_kp',
'host': None,
- 'server': None,
'project_id': '0c2accde-644a-45fa-8c10-e76debc7fbc3',
'changes_since': '2019-08-07T08:03:25Z',
'changes_before': "2019-08-09T08:03:25Z",
@@ -4438,7 +4434,6 @@ class TestListMigrationV280(TestListMigration):
'limit': 1,
'marker': 'test_kp',
'host': None,
- 'server': None,
'user_id': 'dd214878-ca12-40fb-b035-fa7d2c1e86d6',
'changes_since': '2019-08-07T08:03:25Z',
'changes_before': "2019-08-09T08:03:25Z",
@@ -4500,7 +4495,6 @@ class TestListMigrationV280(TestListMigration):
'status': 'migrating',
'limit': 1,
'host': None,
- 'server': None,
'project_id': '0c2accde-644a-45fa-8c10-e76debc7fbc3',
'user_id': 'dd214878-ca12-40fb-b035-fa7d2c1e86d6',
'changes_since': '2019-08-07T08:03:25Z',