better format remote IDs for identity providers

remote-ids are a list, and we should format these values as such,
rather than python representations of lists/arrays.

Closes-Bug: 1478995

Change-Id: Ia6ced0fab2435b8cb486822c676c0dee32613abe

2 files changed, 8 insertions, 7 deletions

diff --git a/openstackclient/tests/identity/v3/fakes.py b/openstackclient/tests/identity/v3/fakes.py
index 61e74f9c..9fe341ed 100644
--- a/openstackclient/tests/identity/v3/fakes.py
+++ b/openstackclient/tests/identity/v3/fakes.py
@@ -261,6 +261,7 @@ TOKEN_WITH_DOMAIN_ID = {
 idp_id = 'test_idp'
 idp_description = 'super exciting IdP description'
 idp_remote_ids = ['entity1', 'entity2']
+formatted_idp_remote_ids = 'entity1, entity2'
 
 IDENTITY_PROVIDER = {
     'id': idp_id,
diff --git a/openstackclient/tests/identity/v3/test_identity_provider.py b/openstackclient/tests/identity/v3/test_identity_provider.py
index cd328c1d..9e9e921e 100644
--- a/openstackclient/tests/identity/v3/test_identity_provider.py
+++ b/openstackclient/tests/identity/v3/test_identity_provider.py
@@ -69,7 +69,7 @@ class TestIdentityProviderCreate(TestIdentityProvider):
             identity_fakes.idp_description,
             True,
             identity_fakes.idp_id,
-            identity_fakes.idp_remote_ids
+            identity_fakes.formatted_idp_remote_ids
         )
         self.assertEqual(datalist, data)
 
@@ -103,7 +103,7 @@ class TestIdentityProviderCreate(TestIdentityProvider):
             identity_fakes.idp_description,
             True,
             identity_fakes.idp_id,
-            identity_fakes.idp_remote_ids
+            identity_fakes.formatted_idp_remote_ids
         )
         self.assertEqual(datalist, data)
 
@@ -137,7 +137,7 @@ class TestIdentityProviderCreate(TestIdentityProvider):
             identity_fakes.idp_description,
             True,
             identity_fakes.idp_id,
-            identity_fakes.idp_remote_ids
+            identity_fakes.formatted_idp_remote_ids
         )
         self.assertEqual(datalist, data)
 
@@ -172,7 +172,7 @@ class TestIdentityProviderCreate(TestIdentityProvider):
             identity_fakes.idp_description,
             True,
             identity_fakes.idp_id,
-            identity_fakes.idp_remote_ids
+            identity_fakes.formatted_idp_remote_ids
         )
         self.assertEqual(datalist, data)
 
@@ -211,7 +211,7 @@ class TestIdentityProviderCreate(TestIdentityProvider):
             identity_fakes.idp_description,
             True,
             identity_fakes.idp_id,
-            identity_fakes.idp_remote_ids
+            identity_fakes.formatted_idp_remote_ids
         )
         self.assertEqual(datalist, data)
 
@@ -253,7 +253,7 @@ class TestIdentityProviderCreate(TestIdentityProvider):
             None,
             False,
             identity_fakes.idp_id,
-            identity_fakes.idp_remote_ids
+            identity_fakes.formatted_idp_remote_ids
         )
         self.assertEqual(datalist, data)
 
@@ -363,7 +363,7 @@ class TestIdentityProviderShow(TestIdentityProvider):
             identity_fakes.idp_description,
             True,
             identity_fakes.idp_id,
-            identity_fakes.idp_remote_ids
+            identity_fakes.formatted_idp_remote_ids
         )
         self.assertEqual(datalist, data)