log take_action parameters in a single place

Previously each command logs take_action parameters explicitly
by using @utils.log_method decorator or log.debug().
Some commands have no logging.

This commit calls a logger in the base class and
drops all logging definition from individual commands.

Closes-Bug: #1532294
Change-Id: I43cd0290a4353c68c075bade9571c940733da1be

1 files changed, 4 insertions, 23 deletions

diff --git a/openstackclient/volume/v1/backup.py b/openstackclient/volume/v1/backup.py
index 4f2ff8bb..32f39fb5 100644
--- a/openstackclient/volume/v1/backup.py
+++ b/openstackclient/volume/v1/backup.py
@@ -16,21 +16,15 @@
 """Volume v1 Backup action implementations"""
 
 import copy
-import logging
 import six
 
-from cliff import command
-from cliff import lister
-from cliff import show
-
+from openstackclient.common import command
 from openstackclient.common import utils
 
 
-class CreateBackup(show.ShowOne):
+class CreateBackup(command.ShowOne):
     """Create new backup"""
 
-    log = logging.getLogger(__name__ + '.CreateBackup')
-
     def get_parser(self, prog_name):
         parser = super(CreateBackup, self).get_parser(prog_name)
         parser.add_argument(
@@ -57,7 +51,6 @@ class CreateBackup(show.ShowOne):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         volume_client = self.app.client_manager.volume
         volume_id = utils.find_resource(volume_client.volumes,
@@ -76,8 +69,6 @@ class CreateBackup(show.ShowOne):
 class DeleteBackup(command.Command):
     """Delete backup(s)"""
 
-    log = logging.getLogger(__name__ + '.DeleteBackup')
-
     def get_parser(self, prog_name):
         parser = super(DeleteBackup, self).get_parser(prog_name)
         parser.add_argument(
@@ -88,7 +79,6 @@ class DeleteBackup(command.Command):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         volume_client = self.app.client_manager.volume
         for backup in parsed_args.backups:
@@ -97,11 +87,9 @@ class DeleteBackup(command.Command):
             volume_client.backups.delete(backup_id)
 
 
-class ListBackup(lister.Lister):
+class ListBackup(command.Lister):
     """List backups"""
 
-    log = logging.getLogger(__name__ + '.ListBackup')
-
     def get_parser(self, prog_name):
         parser = super(ListBackup, self).get_parser(prog_name)
         parser.add_argument(
@@ -112,7 +100,6 @@ class ListBackup(lister.Lister):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
 
         def _format_volume_id(volume_id):
@@ -157,8 +144,6 @@ class ListBackup(lister.Lister):
 class RestoreBackup(command.Command):
     """Restore backup"""
 
-    log = logging.getLogger(__name__ + '.RestoreBackup')
-
     def get_parser(self, prog_name):
         parser = super(RestoreBackup, self).get_parser(prog_name)
         parser.add_argument(
@@ -171,7 +156,6 @@ class RestoreBackup(command.Command):
             help='Volume to restore to (name or ID)')
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         volume_client = self.app.client_manager.volume
         backup = utils.find_resource(volume_client.backups,
@@ -182,11 +166,9 @@ class RestoreBackup(command.Command):
                                               destination_volume.id)
 
 
-class ShowBackup(show.ShowOne):
+class ShowBackup(command.ShowOne):
     """Display backup details"""
 
-    log = logging.getLogger(__name__ + '.ShowBackup')
-
     def get_parser(self, prog_name):
         parser = super(ShowBackup, self).get_parser(prog_name)
         parser.add_argument(
@@ -195,7 +177,6 @@ class ShowBackup(show.ShowOne):
             help='Backup to display (ID only)')
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         volume_client = self.app.client_manager.volume
         backup = utils.find_resource(volume_client.backups,