log take_action parameters in a single place

Previously each command logs take_action parameters explicitly
by using @utils.log_method decorator or log.debug().
Some commands have no logging.

This commit calls a logger in the base class and
drops all logging definition from individual commands.

Closes-Bug: #1532294
Change-Id: I43cd0290a4353c68c075bade9571c940733da1be

1 files changed, 5 insertions, 23 deletions

diff --git a/openstackclient/volume/v2/backup.py b/openstackclient/volume/v2/backup.py
index bc919d0b..64ca97ae 100644
--- a/openstackclient/volume/v2/backup.py
+++ b/openstackclient/volume/v2/backup.py
@@ -15,21 +15,16 @@
 """Volume v2 Backup action implementations"""
 
 import copy
-import logging
 
-from cliff import command
-from cliff import lister
-from cliff import show
 import six
 
+from openstackclient.common import command
 from openstackclient.common import utils
 
 
-class CreateBackup(show.ShowOne):
+class CreateBackup(command.ShowOne):
     """Create new backup"""
 
-    log = logging.getLogger(__name__ + ".CreateBackup")
-
     def get_parser(self, prog_name):
         parser = super(CreateBackup, self).get_parser(prog_name)
         parser.add_argument(
@@ -56,7 +51,6 @@ class CreateBackup(show.ShowOne):
         return parser
 
     def take_action(self, parsed_args):
-        self.log.debug("take_action: (%s)", parsed_args)
         volume_client = self.app.client_manager.volume
         volume_id = utils.find_resource(
             volume_client.volumes, parsed_args.volume).id
@@ -73,8 +67,6 @@ class CreateBackup(show.ShowOne):
 class DeleteBackup(command.Command):
     """Delete backup(s)"""
 
-    log = logging.getLogger(__name__ + ".DeleteBackup")
-
     def get_parser(self, prog_name):
         parser = super(DeleteBackup, self).get_parser(prog_name)
         parser.add_argument(
@@ -86,7 +78,6 @@ class DeleteBackup(command.Command):
         return parser
 
     def take_action(self, parsed_args):
-        self.log.debug("take_action: (%s)", parsed_args)
         volume_client = self.app.client_manager.volume
         for backup in parsed_args.backups:
             backup_id = utils.find_resource(
@@ -94,11 +85,9 @@ class DeleteBackup(command.Command):
             volume_client.backups.delete(backup_id)
 
 
-class ListBackup(lister.Lister):
+class ListBackup(command.Lister):
     """List backups"""
 
-    log = logging.getLogger(__name__ + ".ListBackup")
-
     def get_parser(self, prog_name):
         parser = super(ListBackup, self).get_parser(prog_name)
         parser.add_argument(
@@ -110,7 +99,6 @@ class ListBackup(lister.Lister):
         return parser
 
     def take_action(self, parsed_args):
-        self.log.debug("take_action: (%s)", parsed_args)
 
         def _format_volume_id(volume_id):
             """Return a volume name if available
@@ -151,11 +139,9 @@ class ListBackup(lister.Lister):
                 ) for s in data))
 
 
-class RestoreBackup(show.ShowOne):
+class RestoreBackup(command.ShowOne):
     """Restore backup"""
 
-    log = logging.getLogger(__name__ + ".RestoreBackup")
-
     def get_parser(self, prog_name):
         parser = super(RestoreBackup, self).get_parser(prog_name)
         parser.add_argument(
@@ -171,7 +157,6 @@ class RestoreBackup(show.ShowOne):
         return parser
 
     def take_action(self, parsed_args):
-        self.log.debug("take_action: (%s)", parsed_args)
         volume_client = self.app.client_manager.volume
         backup = utils.find_resource(volume_client.backups, parsed_args.backup)
         destination_volume = utils.find_resource(volume_client.volumes,
@@ -179,11 +164,9 @@ class RestoreBackup(show.ShowOne):
         return volume_client.restores.restore(backup.id, destination_volume.id)
 
 
-class ShowBackup(show.ShowOne):
+class ShowBackup(command.ShowOne):
     """Display backup details"""
 
-    log = logging.getLogger(__name__ + ".ShowBackup")
-
     def get_parser(self, prog_name):
         parser = super(ShowBackup, self).get_parser(prog_name)
         parser.add_argument(
@@ -193,7 +176,6 @@ class ShowBackup(show.ShowOne):
         return parser
 
     def take_action(self, parsed_args):
-        self.log.debug("take_action: (%s)", parsed_args)
         volume_client = self.app.client_manager.volume
         backup = utils.find_resource(volume_client.backups,
                                      parsed_args.backup)