diff options
| author | Daniel Speichert <Daniel_Speichert@comcast.com> | 2017-11-14 11:14:11 -0500 |
|---|---|---|
| committer | Dean Troyer <dtroyer@gmail.com> | 2017-12-11 18:07:45 -0600 |
| commit | 116526275d0953fda93c7ff8eacd8631c5af68d5 (patch) | |
| tree | 5c0747110151b19fb365b1ee4fe7adfc72c91f2e /openstackclient | |
| parent | 4742d4df7089cd10d03635a1b3dbca9e7e80b1cc (diff) | |
| download | python-openstackclient-116526275d0953fda93c7ff8eacd8631c5af68d5.tar.gz | |
Send 'changes-since' instead of 'changes_since' query parameter
Per API reference, only 'changes-since' is accepted and the variant
with underscore is ignored, making the CLI functionality broken.
[dtroyer] added release note and fixed unit tests.
Change-Id: I0c596531a8af03da17d5ce39d75b12e941403aa5
Closes-Bug: 1732216
Diffstat (limited to 'openstackclient')
| -rw-r--r-- | openstackclient/compute/v2/server.py | 13 | ||||
| -rw-r--r-- | openstackclient/tests/unit/compute/v2/test_server.py | 4 |
2 files changed, 9 insertions, 8 deletions
diff --git a/openstackclient/compute/v2/server.py b/openstackclient/compute/v2/server.py index 03419982..3b805639 100644 --- a/openstackclient/compute/v2/server.py +++ b/openstackclient/compute/v2/server.py @@ -1056,17 +1056,18 @@ class ListServer(command.Lister): 'all_tenants': parsed_args.all_projects, 'user_id': user_id, 'deleted': parsed_args.deleted, - 'changes_since': parsed_args.changes_since, + 'changes-since': parsed_args.changes_since, } LOG.debug('search options: %s', search_opts) - if search_opts['changes_since']: + if search_opts['changes-since']: try: - timeutils.parse_isotime(search_opts['changes_since']) + timeutils.parse_isotime(search_opts['changes-since']) except ValueError: - raise exceptions.CommandError(_('Invalid changes-since value:' - ' %s') % search_opts['changes' - '_since']) + raise exceptions.CommandError( + _('Invalid changes-since value: %s') % + search_opts['changes-since'] + ) if parsed_args.long: columns = ( diff --git a/openstackclient/tests/unit/compute/v2/test_server.py b/openstackclient/tests/unit/compute/v2/test_server.py index ad52e232..99cdfb77 100644 --- a/openstackclient/tests/unit/compute/v2/test_server.py +++ b/openstackclient/tests/unit/compute/v2/test_server.py @@ -1584,7 +1584,7 @@ class TestServerList(TestServer): 'all_tenants': False, 'user_id': None, 'deleted': False, - 'changes_since': None, + 'changes-since': None, } # Default params of the core function of the command in the case of no @@ -1791,7 +1791,7 @@ class TestServerList(TestServer): parsed_args = self.check_parser(self.cmd, arglist, verifylist) columns, data = self.cmd.take_action(parsed_args) - self.search_opts['changes_since'] = '2016-03-04T06:27:59Z' + self.search_opts['changes-since'] = '2016-03-04T06:27:59Z' self.search_opts['deleted'] = True self.servers_mock.list.assert_called_with(**self.kwargs) |