summaryrefslogtreecommitdiff
path: root/openstackclient
diff options
context:
space:
mode:
authorStephen Finucane <sfinucan@redhat.com>2022-09-14 13:40:17 +0100
committerStephen Finucane <sfinucan@redhat.com>2022-09-14 13:44:02 +0100
commit3fc585332f79358489285eabc298e01007599128 (patch)
tree870b8a3eea2bbd36f00cc143488a34af6e749add /openstackclient
parentc6065c7a4796ad0a679a13cb6bd2b3b5a271f5cb (diff)
downloadpython-openstackclient-3fc585332f79358489285eabc298e01007599128.tar.gz
volume: Volume names are optional
Who knew? Change-Id: I1c1a811c0db59250e8a20a87f25c2662bc3ab3e8 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Diffstat (limited to 'openstackclient')
-rw-r--r--openstackclient/tests/unit/volume/v2/test_volume.py4
-rw-r--r--openstackclient/volume/v2/volume.py3
2 files changed, 3 insertions, 4 deletions
diff --git a/openstackclient/tests/unit/volume/v2/test_volume.py b/openstackclient/tests/unit/volume/v2/test_volume.py
index ec82e674..b6e9f487 100644
--- a/openstackclient/tests/unit/volume/v2/test_volume.py
+++ b/openstackclient/tests/unit/volume/v2/test_volume.py
@@ -108,11 +108,9 @@ class TestVolumeCreate(TestVolume):
def test_volume_create_min_options(self):
arglist = [
'--size', str(self.new_volume.size),
- self.new_volume.name,
]
verifylist = [
('size', self.new_volume.size),
- ('name', self.new_volume.name),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
@@ -124,7 +122,7 @@ class TestVolumeCreate(TestVolume):
self.volumes_mock.create.assert_called_with(
size=self.new_volume.size,
snapshot_id=None,
- name=self.new_volume.name,
+ name=None,
description=None,
volume_type=None,
availability_zone=None,
diff --git a/openstackclient/volume/v2/volume.py b/openstackclient/volume/v2/volume.py
index 6d14b360..1e1fde92 100644
--- a/openstackclient/volume/v2/volume.py
+++ b/openstackclient/volume/v2/volume.py
@@ -82,10 +82,11 @@ class CreateVolume(command.ShowOne):
_description = _("Create new volume")
def get_parser(self, prog_name):
- parser = super(CreateVolume, self).get_parser(prog_name)
+ parser = super().get_parser(prog_name)
parser.add_argument(
"name",
metavar="<name>",
+ nargs="?",
help=_("Volume name"),
)
parser.add_argument(