diff options
| author | Eric Fried <openstack@fried.cc> | 2019-10-29 08:55:51 -0500 |
|---|---|---|
| committer | Eric Fried <openstack@fried.cc> | 2019-10-31 16:53:30 +0000 |
| commit | 40f74816c11c2d46eb0595795ef3611c18920482 (patch) | |
| tree | 1fb0a5833f34f89e6815d5da2e7ed34c16b270e1 /openstackclient | |
| parent | f1d742f32adeb662a3fdf8fa3ef3bc391e71ed81 (diff) | |
| download | python-openstackclient-40f74816c11c2d46eb0595795ef3611c18920482.tar.gz | |
Remove redundant OpenStackShell.prepare_to_run_command
osc-lib's OpenStackShell.prepare_to_run_command has been a superset of
python-openstackclient's since at least osc-lib 1.4.0. We require 1.14.0
now, so the redundant override can be removed.
Change-Id: I5658e3df5af1100e139623505d0375588edae63c
Diffstat (limited to 'openstackclient')
| -rw-r--r-- | openstackclient/shell.py | 26 |
1 files changed, 0 insertions, 26 deletions
diff --git a/openstackclient/shell.py b/openstackclient/shell.py index 7fbda1ae..755af24d 100644 --- a/openstackclient/shell.py +++ b/openstackclient/shell.py @@ -139,32 +139,6 @@ class OpenStackShell(shell.OpenStackShell): pw_func=shell.prompt_for_password, ) - def prepare_to_run_command(self, cmd): - """Set up auth and API versions""" - - # TODO(dtroyer): Move this to osc-lib, remove entire method when 1.4.0 - # release is minimum version is in global-requirements - # NOTE(dtroyer): If auth is not required for a command, skip - # get_one_Cloud()'s validation to avoid loading plugins - validate = cmd.auth_required - - # Force skipping auth for commands that do not need it - # NOTE(dtroyer): This is here because ClientManager does not have - # visibility into the Command object to get - # auth_required. It needs to move into osc-lib - self.client_manager._auth_required = cmd.auth_required - - # Validate auth options - self.cloud = self.cloud_config.get_one_cloud( - cloud=self.options.cloud, - argparse=self.options, - validate=validate, - ) - # Push the updated args into ClientManager - self.client_manager._cli_options = self.cloud - - return super(OpenStackShell, self).prepare_to_run_command(cmd) - def main(argv=None): if argv is None: |
