Add name option to 'port set'

Port's name can be updated in NeutronClient and it is a very
good feature for a user to have the ability to rename a port.
This was missing in the openstackclient, and the same has been
added in this patch.

Change-Id: I6e712ef08ab1c0a23786c4bb6972d3e0f8f0f999
Implements: blueprint neutron-client

2 files changed, 10 insertions, 2 deletions

diff --git a/openstackclient/network/v2/port.py b/openstackclient/network/v2/port.py
index 45ad1c72..d7866ccc 100644
--- a/openstackclient/network/v2/port.py
+++ b/openstackclient/network/v2/port.py
@@ -97,10 +97,11 @@ def _get_attrs(client_manager, parsed_args):
     if parsed_args.host:
         attrs['binding:host_id'] = parsed_args.host
 
+    # It is possible that name is not updated during 'port set'
+    if parsed_args.name is not None:
+        attrs['name'] = str(parsed_args.name)
     # The remaining options do not support 'port set' command, so they require
     # additional check
-    if 'name' in parsed_args and parsed_args.name is not None:
-        attrs['name'] = str(parsed_args.name)
     if 'mac_address' in parsed_args and parsed_args.mac_address is not None:
         attrs['mac_address'] = parsed_args.mac_address
     if 'network' in parsed_args and parsed_args.network is not None:
@@ -343,6 +344,10 @@ class SetPort(command.Command):
             help='Disable port',
         )
         parser.add_argument(
+            '--name',
+            metavar="<name>",
+            help=('Set port name'))
+        parser.add_argument(
             'port',
             metavar="<port>",
             help=("Port to modify (name or ID)")
diff --git a/openstackclient/tests/network/v2/test_port.py b/openstackclient/tests/network/v2/test_port.py
index cb1af2b8..31454dba 100644
--- a/openstackclient/tests/network/v2/test_port.py
+++ b/openstackclient/tests/network/v2/test_port.py
@@ -319,6 +319,7 @@ class TestSetPort(TestPort):
             '--vnic-type', 'macvtap',
             '--binding-profile', 'foo=bar',
             '--host', 'binding-host-id-xxxx',
+            '--name', 'newName',
             self._port.name,
         ]
         verifylist = [
@@ -326,6 +327,7 @@ class TestSetPort(TestPort):
             ('vnic_type', 'macvtap'),
             ('binding_profile', {'foo': 'bar'}),
             ('host', 'binding-host-id-xxxx'),
+            ('name', 'newName')
         ]
 
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
@@ -336,6 +338,7 @@ class TestSetPort(TestPort):
             'binding:vnic_type': 'macvtap',
             'binding:profile': {'foo': 'bar'},
             'binding:host_id': 'binding-host-id-xxxx',
+            'name': 'newName',
         }
         self.network.update_port.assert_called_once_with(self._port, **attrs)
         self.assertIsNone(result)