summaryrefslogtreecommitdiff
path: root/openstackclient
diff options
context:
space:
mode:
authorJenkins <jenkins@review.openstack.org>2016-04-28 16:14:13 +0000
committerGerrit Code Review <review@openstack.org>2016-04-28 16:14:13 +0000
commit6bf60180a2968d93946fdc8b924cf4057f5713df (patch)
treeee6d8021d7858fbb63f0b3b40d3ecbde0ae2e579 /openstackclient
parent941217a5f391941925339acaeb6892fe5d1cf5b2 (diff)
parent4524b3605fa4260a2f916421eebfc7a99b320e4b (diff)
downloadpython-openstackclient-6bf60180a2968d93946fdc8b924cf4057f5713df.tar.gz
Merge "Fix error in flavor set/unset command"
Diffstat (limited to 'openstackclient')
-rw-r--r--openstackclient/compute/v2/flavor.py6
-rw-r--r--openstackclient/tests/compute/v2/test_flavor.py12
2 files changed, 12 insertions, 6 deletions
diff --git a/openstackclient/compute/v2/flavor.py b/openstackclient/compute/v2/flavor.py
index 29e0e9d4..04674614 100644
--- a/openstackclient/compute/v2/flavor.py
+++ b/openstackclient/compute/v2/flavor.py
@@ -239,7 +239,8 @@ class SetFlavor(command.Command):
def take_action(self, parsed_args):
compute_client = self.app.client_manager.compute
- flavor = compute_client.flavors.find(name=parsed_args.flavor)
+ flavor = utils.find_resource(compute_client.flavors,
+ parsed_args.flavor)
flavor.set_keys(parsed_args.property)
@@ -289,5 +290,6 @@ class UnsetFlavor(command.Command):
def take_action(self, parsed_args):
compute_client = self.app.client_manager.compute
- flavor = compute_client.flavors.find(name=parsed_args.flavor)
+ flavor = utils.find_resource(compute_client.flavors,
+ parsed_args.flavor)
flavor.unset_keys(parsed_args.property)
diff --git a/openstackclient/tests/compute/v2/test_flavor.py b/openstackclient/tests/compute/v2/test_flavor.py
index 03ca8807..fa29111b 100644
--- a/openstackclient/tests/compute/v2/test_flavor.py
+++ b/openstackclient/tests/compute/v2/test_flavor.py
@@ -288,8 +288,10 @@ class TestFlavorSet(TestFlavor):
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
result = self.cmd.take_action(parsed_args)
-
- self.flavors_mock.find.assert_called_with(name='baremetal')
+ try:
+ self.flavors_mock.find.assert_called_with(name=parsed_args.flavor)
+ except Exception:
+ self.flavors_mock.get.assert_called_with(parsed_args.flavor)
self.assertIsNone(result)
@@ -382,6 +384,8 @@ class TestFlavorUnset(TestFlavor):
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
result = self.cmd.take_action(parsed_args)
-
- self.flavors_mock.find.assert_called_with(name='baremetal')
+ try:
+ self.flavors_mock.find.assert_called_with(name=parsed_args.flavor)
+ except Exception:
+ self.flavors_mock.get.assert_called_with(parsed_args.flavor)
self.assertIsNone(result)