summaryrefslogtreecommitdiff
path: root/openstackclient
diff options
context:
space:
mode:
authorRodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>2017-10-10 14:04:40 +0100
committerRodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>2017-10-10 14:04:40 +0100
commit885b1149c309667c6e4c3092b67fef3c01a15178 (patch)
treed53cf8fbf1dbec54627bdb0cc3b6340a11cd73e3 /openstackclient
parenta87bd58fb4de5dc5f99193b88d2a3f8bd1338c52 (diff)
downloadpython-openstackclient-885b1149c309667c6e4c3092b67fef3c01a15178.tar.gz
Avoid default mutable values in arguments
Mutable values shouldn't be used as default values in function arguments [1]. [1] http://docs.python-guide.org/en/latest/writing/gotchas/ Change-Id: I3c7f915f0409c77f4c430467365eb1bcfd7757b3
Diffstat (limited to 'openstackclient')
-rw-r--r--openstackclient/network/sdk_utils.py3
1 files changed, 2 insertions, 1 deletions
diff --git a/openstackclient/network/sdk_utils.py b/openstackclient/network/sdk_utils.py
index 04f168be..9f085617 100644
--- a/openstackclient/network/sdk_utils.py
+++ b/openstackclient/network/sdk_utils.py
@@ -16,7 +16,7 @@ import six
def get_osc_show_columns_for_sdk_resource(
sdk_resource,
osc_column_map,
- invisible_columns=[]
+ invisible_columns=None
):
"""Get and filter the display and attribute columns for an SDK resource.
@@ -40,6 +40,7 @@ def get_osc_show_columns_for_sdk_resource(
# Build the OSC column names to display for the SDK resource.
attr_map = {}
display_columns = list(resource_dict.keys())
+ invisible_columns = [] if invisible_columns is None else invisible_columns
for col_name in invisible_columns:
if col_name in display_columns:
display_columns.remove(col_name)