summaryrefslogtreecommitdiff
path: root/openstackclient
diff options
context:
space:
mode:
authorZuul <zuul@review.opendev.org>2021-03-20 05:54:26 +0000
committerGerrit Code Review <review@openstack.org>2021-03-20 05:54:26 +0000
commitb527ec15a959457a933f7b1bf18cf38473e5d81e (patch)
tree5db06a730ce72fe2cab4fd0ce41def9011391c1d /openstackclient
parent7c6b689fdd2712ddd19f14e5a6762acfe60d543c (diff)
parentc58f0277a74a0f94638689de7db297f48243048e (diff)
downloadpython-openstackclient-b527ec15a959457a933f7b1bf18cf38473e5d81e.tar.gz
Merge "network: Make 'network qos rule create --type' option required"
Diffstat (limited to 'openstackclient')
-rw-r--r--openstackclient/network/v2/network_qos_rule.py4
1 files changed, 1 insertions, 3 deletions
diff --git a/openstackclient/network/v2/network_qos_rule.py b/openstackclient/network/v2/network_qos_rule.py
index 28c5600a..2e4b385d 100644
--- a/openstackclient/network/v2/network_qos_rule.py
+++ b/openstackclient/network/v2/network_qos_rule.py
@@ -84,9 +84,6 @@ def _get_attrs(network_client, parsed_args, is_create=False):
{'rule_id': parsed_args.id})
raise exceptions.CommandError(msg)
else:
- if not parsed_args.type:
- msg = _('"Create" rule command requires argument "type"')
- raise exceptions.CommandError(msg)
rule_type = parsed_args.type
if parsed_args.max_kbps is not None:
attrs['max_kbps'] = parsed_args.max_kbps
@@ -188,6 +185,7 @@ class CreateNetworkQosRule(command.ShowOne):
parser.add_argument(
'--type',
metavar='<type>',
+ required=True,
choices=[RULE_TYPE_MINIMUM_BANDWIDTH,
RULE_TYPE_DSCP_MARKING,
RULE_TYPE_BANDWIDTH_LIMIT],