Merge "Implement "address scope set" command"

2 files changed, 115 insertions, 0 deletions

diff --git a/openstackclient/network/v2/address_scope.py b/openstackclient/network/v2/address_scope.py
index 86f39c34..fac0849f 100644
--- a/openstackclient/network/v2/address_scope.py
+++ b/openstackclient/network/v2/address_scope.py
@@ -14,6 +14,7 @@
 """Address scope action implementations"""
 
 from openstackclient.common import command
+from openstackclient.common import exceptions
 from openstackclient.common import utils
 from openstackclient.i18n import _
 from openstackclient.identity import common as identity_common
@@ -142,6 +143,53 @@ class ListAddressScope(command.Lister):
                 ) for s in data))
 
 
+class SetAddressScope(command.Command):
+    """Set address scope properties"""
+
+    def get_parser(self, prog_name):
+        parser = super(SetAddressScope, self).get_parser(prog_name)
+        parser.add_argument(
+            'address_scope',
+            metavar="<address-scope>",
+            help=_("Address scope to modify (name or ID)")
+        )
+        parser.add_argument(
+            '--name',
+            metavar="<name>",
+            help=_('Set address scope name')
+        )
+        share_group = parser.add_mutually_exclusive_group()
+        share_group.add_argument(
+            '--share',
+            action='store_true',
+            help=_('Share the address scope between projects')
+        )
+        share_group.add_argument(
+            '--no-share',
+            action='store_true',
+            help=_('Do not share the address scope between projects')
+        )
+
+        return parser
+
+    def take_action(self, parsed_args):
+        client = self.app.client_manager.network
+        obj = client.find_address_scope(
+            parsed_args.address_scope,
+            ignore_missing=False)
+        attrs = {}
+        if parsed_args.name is not None:
+            attrs['name'] = parsed_args.name
+        if parsed_args.share:
+            attrs['shared'] = True
+        if parsed_args.no_share:
+            attrs['shared'] = False
+        if attrs == {}:
+            msg = "Nothing specified to be set."
+            raise exceptions.CommandError(msg)
+        client.update_address_scope(obj, **attrs)
+
+
 class ShowAddressScope(command.ShowOne):
     """Display address scope details"""
 
diff --git a/openstackclient/tests/network/v2/test_address_scope.py b/openstackclient/tests/network/v2/test_address_scope.py
index da658fef..ac94b489 100644
--- a/openstackclient/tests/network/v2/test_address_scope.py
+++ b/openstackclient/tests/network/v2/test_address_scope.py
@@ -14,6 +14,7 @@
 import copy
 import mock
 
+from openstackclient.common import exceptions
 from openstackclient.network.v2 import address_scope
 from openstackclient.tests import fakes
 from openstackclient.tests.identity.v3 import fakes as identity_fakes_v3
@@ -237,6 +238,72 @@ class TestListAddressScope(TestAddressScope):
         self.assertEqual(self.data, list(data))
 
 
+class TestSetAddressScope(TestAddressScope):
+
+    # The address scope to set.
+    _address_scope = network_fakes.FakeAddressScope.create_one_address_scope()
+
+    def setUp(self):
+        super(TestSetAddressScope, self).setUp()
+        self.network.update_address_scope = mock.Mock(return_value=None)
+        self.network.find_address_scope = mock.Mock(
+            return_value=self._address_scope)
+
+        # Get the command object to test
+        self.cmd = address_scope.SetAddressScope(self.app, self.namespace)
+
+    def test_set_nothing(self):
+        arglist = [self._address_scope.name, ]
+        verifylist = [
+            ('address_scope', self._address_scope.name),
+        ]
+
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+        self.assertRaises(exceptions.CommandError, self.cmd.take_action,
+                          parsed_args)
+
+    def test_set_name_and_share(self):
+        arglist = [
+            '--name', 'new_address_scope',
+            '--share',
+            self._address_scope.name,
+        ]
+        verifylist = [
+            ('name', 'new_address_scope'),
+            ('share', True),
+            ('address_scope', self._address_scope.name),
+        ]
+
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+        result = self.cmd.take_action(parsed_args)
+        attrs = {
+            'name': "new_address_scope",
+            'shared': True,
+        }
+        self.network.update_address_scope.assert_called_with(
+            self._address_scope, **attrs)
+        self.assertIsNone(result)
+
+    def test_set_no_share(self):
+        arglist = [
+            '--no-share',
+            self._address_scope.name,
+        ]
+        verifylist = [
+            ('no_share', True),
+            ('address_scope', self._address_scope.name),
+        ]
+
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+        result = self.cmd.take_action(parsed_args)
+        attrs = {
+            'shared': False,
+        }
+        self.network.update_address_scope.assert_called_with(
+            self._address_scope, **attrs)
+        self.assertIsNone(result)
+
+
 class TestShowAddressScope(TestAddressScope):
 
     # The address scope to show.