summaryrefslogtreecommitdiff
path: root/openstackclient/tests/functional/volume/v1
diff options
context:
space:
mode:
Diffstat (limited to 'openstackclient/tests/functional/volume/v1')
-rw-r--r--openstackclient/tests/functional/volume/v1/common.py23
1 files changed, 6 insertions, 17 deletions
diff --git a/openstackclient/tests/functional/volume/v1/common.py b/openstackclient/tests/functional/volume/v1/common.py
index 04eb1f48..75587478 100644
--- a/openstackclient/tests/functional/volume/v1/common.py
+++ b/openstackclient/tests/functional/volume/v1/common.py
@@ -20,25 +20,14 @@ class BaseVolumeTests(volume_base.BaseVolumeTests):
@classmethod
def setUpClass(cls):
- super(BaseVolumeTests, cls).setUpClass()
- # TODO(dtroyer): This needs to be updated to specifically check for
- # Volume v1 rather than just 'volume', but for now
- # that is enough until we get proper version negotiation
- cls.haz_volume_v1 = cls.is_service_enabled('volume')
+ super().setUpClass()
+ cls.haz_volume_v1 = cls.is_service_enabled('block-storage', '1.0')
def setUp(self):
- super(BaseVolumeTests, self).setUp()
-
- # This class requires Volume v1
- # if not self.haz_volume_v1:
- # self.skipTest("No Volume v1 service present")
-
- # TODO(dtroyer): We really want the above to work but right now
- # (12Sep2017) DevStack still creates a 'volume'
- # service type even though there is no service behind
- # it. Until that is fixed we need to just skip the
- # volume v1 functional tests in master.
- self.skipTest("No Volume v1 service present")
+ super().setUp()
+
+ if not self.haz_volume_v1:
+ self.skipTest("No Volume v1 service present")
ver_fixture = fixtures.EnvironmentVariable(
'OS_VOLUME_API_VERSION', '1'