summaryrefslogtreecommitdiff
path: root/openstackclient
diff options
context:
space:
mode:
Diffstat (limited to 'openstackclient')
-rw-r--r--openstackclient/network/v2/network_agent.py4
-rw-r--r--openstackclient/tests/unit/network/v2/test_network_agent.py4
2 files changed, 4 insertions, 4 deletions
diff --git a/openstackclient/network/v2/network_agent.py b/openstackclient/network/v2/network_agent.py
index dd3fdc24..1334f77e 100644
--- a/openstackclient/network/v2/network_agent.py
+++ b/openstackclient/network/v2/network_agent.py
@@ -282,11 +282,11 @@ class SetNetworkAgent(command.Command):
attrs = {}
if parsed_args.description is not None:
attrs['description'] = str(parsed_args.description)
- # TODO(huanxuan): Also update by the new attribute name
- # "is_admin_state_up" after sdk 0.9.12
if parsed_args.enable:
+ attrs['is_admin_state_up'] = True
attrs['admin_state_up'] = True
if parsed_args.disable:
+ attrs['is_admin_state_up'] = False
attrs['admin_state_up'] = False
client.update_agent(obj, **attrs)
diff --git a/openstackclient/tests/unit/network/v2/test_network_agent.py b/openstackclient/tests/unit/network/v2/test_network_agent.py
index 0d741e06..9bb3f090 100644
--- a/openstackclient/tests/unit/network/v2/test_network_agent.py
+++ b/openstackclient/tests/unit/network/v2/test_network_agent.py
@@ -322,8 +322,6 @@ class TestRemoveNetworkFromAgent(TestNetworkAgent):
self.agent, self.net)
-# TODO(huanxuan): Also update by the new attribute name
-# "is_admin_state_up" after sdk 0.9.12
class TestSetNetworkAgent(TestNetworkAgent):
_network_agent = (
@@ -372,6 +370,7 @@ class TestSetNetworkAgent(TestNetworkAgent):
attrs = {
'description': 'new_description',
'admin_state_up': True,
+ 'is_admin_state_up': True,
}
self.network.update_agent.assert_called_once_with(
self._network_agent, **attrs)
@@ -393,6 +392,7 @@ class TestSetNetworkAgent(TestNetworkAgent):
attrs = {
'admin_state_up': False,
+ 'is_admin_state_up': False,
}
self.network.update_agent.assert_called_once_with(
self._network_agent, **attrs)