summaryrefslogtreecommitdiff
path: root/openstackclient
Commit message (Collapse)AuthorAgeFilesLines
* image: Fail if we can't find an imageStephen Finucane2022-12-012-9/+26
| | | | | | | | Whenever we attempt to find a provided image, we generally want to fail fast if they can't be found. This wasn't happening. Fix it. Change-Id: Ibea38354a78381cb87d287f03726ecd03ecd246d Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* image: Rename importStephen Finucane2022-12-011-13/+15
| | | | | | | This makes the code a little clearer. Change-Id: Ib552d510ca484571e59363ef15fe5e2cc0a2f4e1 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* Revert "Don't look up project by id if given id"Stephen Finucane2022-11-301-9/+5
| | | | | | | | | | | | | | | This reverts commit 042be7c7fe89f5a1a190af90d5980205d995941b. This solution worked but it was confusing. The issue that the author was seeing was presumably due to users not being able to list projects but in theory the 'openstackclient.image.common.find_project' function that was being called here should have already handle this. It transpires however that there was a bug in this and we weren't correctly handling HTTP 403 errors correctly. This bug has since been fixed in change I2ea2def607ec5be112e42d53a1e660fef0cdd69c meaning this change is no longer necessary. Remove it and simplify the code somewhat. Change-Id: I108efec2c8deda50fcb9cc84f313602bed2ac15c Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* Merge "Improve `server dump create` helptext"Zuul2022-11-291-2/+3
|\
| * Improve `server dump create` helptextArtom Lifshitz2022-10-261-2/+3
| | | | | | | | | | | | | | | | | | | | | | The `server dump create` command instructs Nova to trigger a crash dump in the guest OS. Assuming the guest supports this, the resulting dump file will be located in the guest, in a location dependent on the guest OS. Explain all that in the helptext. Story: 2010384 Change-Id: If940ed5cce6c5ab4193ab1494738149370da9aad
* | Merge "Add note about microversion 2.87 in server rescue help"Zuul2022-11-291-1/+5
|\ \
| * | Add note about microversion 2.87 in server rescue helpmelanie witt2022-11-071-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The ability to rescue a volume-backed server was added in compute microversion 2.87 [1]. This adds a note to the command help to improve user experience. [1] https://docs.openstack.org/nova/latest/user/rescue.html Change-Id: I5f40c3ca28e13bd1f979bc5f8c337302a3b9a5be
* | | Add test for creating volume from sourcewhoami-rajat2022-11-232-4/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch adds a test to create a new volume from source. We also include code changes to pass the right size i.e. either size passed by the user via --size argument or the source volume size. This case is already handled at the API layer[1] but it helps being consistent with passing the right size value as in case of creating a volume from snapshot or backup. [1] https://github.com/openstack/cinder/blob/7c1a5ce7b11964da4537fd6a7d157ede646b9e94/cinder/api/v3/volumes.py#L381-L382 Change-Id: Idc71636dad6bb678fe24f19b0836d2e9bd92d7d2
* | | Change --size helptext to include backupwhoami-rajat2022-11-221-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | Followup from [1]. Modifying help text of --size argument to include --backup option. [1] https://review.opendev.org/c/openstack/python-openstackclient/+/864893 Change-Id: I12cf60079ebcfe1cd059602fbfc1a13c8fe86803
* | | Add option to create volume from backupwhoami-rajat2022-11-212-3/+99
| | | | | | | | | | | | | | | | | | | | | | | | Support for creating a volume from backup was added in microversio 3.47. This patch adds a --backup option to the volume create command to add that support. Change-Id: Ib26d2d335475d9aacbf77c0fd7b7cda2ba743943
* | | Merge "image: Add 'image stage' command"Zuul2022-11-163-25/+157
|\ \ \
| * | | image: Add 'image stage' commandStephen Finucane2022-11-093-25/+157
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is the equivalent of the 'image-stage' glanceclient command. Change-Id: I10b01ef145740a2f7ffe5a8c7ce0296df0ece0bd Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "image: Simplify handling of data provided via stdin"Zuul2022-11-162-103/+82
|\ \ \ \ | |/ / /
| * | | image: Simplify handling of data provided via stdinStephen Finucane2022-11-092-103/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This was unnecessarily complex. Change-Id: I8289d5ce7356d8bc89425590a7f71bca91a6d396 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "image: Ignore '--progress' if providing image data from stdin"Zuul2022-11-162-1/+34
|\ \ \ \ | |/ / /
| * | | image: Ignore '--progress' if providing image data from stdinStephen Finucane2022-11-092-1/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | You can provide data via stdin when creating an image. Using this with '--progress' makes no sense and causes an error currently. Fix this. Change-Id: I3c2d658b72a7c62931b779b0d19bb97f60a0c655 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "Moved hypervisor to the SDK"Zuul2022-11-163-201/+300
|\ \ \ \
| * | | | Moved hypervisor to the SDKViolet Kurtz2022-11-093-201/+300
| | | | | | | | | | | | | | | | | | | | Change-Id: Ie955fb4d27c30e044626732a1f3e0f141cb85aa5
* | | | | Merge "Use the compute SDK in usage commands"Zuul2022-11-162-66/+48
|\ \ \ \ \
| * | | | | Use the compute SDK in usage commandsDaniel Wilson2022-10-252-66/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update usage list and usage show to use the compute component of the OpenStack SDK instead of directly using the nova interface. Change-Id: I1c4d2247c9c1a577ed9efad7e8332e7c9b974ad5
* | | | | | Merge "compute: Add missing microversion check for networks"Zuul2022-11-162-17/+91
|\ \ \ \ \ \
| * | | | | | compute: Add missing microversion check for networksStephen Finucane2022-11-082-17/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The 'auto' and 'none' network allocation policies are only supported on compute API microversion 2.37 or later. Enforce this in the code. Change-Id: I90f8fb1e61ead4bd406ea76bbeb731b913805b13 Signed-off-by: Stephen Finucane <sfinucan@redhat.com> Story: 2010385 Task: 46657
* | | | | | | Merge "compute: Fix '--network none/auto' handling"Zuul2022-11-162-17/+43
|\ \ \ \ \ \ \ | |/ / / / / /
| * | | | | | compute: Fix '--network none/auto' handlingStephen Finucane2022-11-082-17/+43
| | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This should lookup a network called 'none' or 'auto', not do the equivalent on '--nic none' or '--nic auto'. Correct this. Change-Id: I3c5acc49bfe8162d8fb6110603da56d56090b78f Signed-off-by: Stephen Finucane <sfinucan@redhat.com> Story: 2010385 Task: 46658
* | | | | | Docstring fix for CreateVolumeAttachment classJadon Naas2022-11-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The command "volume attachment create" has a typo in the docstring. The docstring says to use "server add volume", but the command is actually "server volume add". This change fixes the typo in the docstring. Task: 46781 Story: 2010401 Change-Id: Ie19a24ead100dd9177669653a7a9997772ef4538
* | | | | | tests: Convert more functional tests to use 'parse_output'Stephen Finucane2022-11-086-113/+105
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I1d968181eb196c6df4583c772c67ed58bc7ba585 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | | | tests: Move json decoding to base test classStephen Finucane2022-11-082-30/+48
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We do this everywhere. Add a simple knob to simplify the pattern. Only one use is migrated initially. The rest will be done separately. Change-Id: Ic3b8958bd4fb1459a8ac3adaff216c2a26628491 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | | Merge "compute: Add '--no-network', '--auto-network' flags"Zuul2022-11-082-38/+130
|\ \ \ \ \ | |_|_|/ / |/| | | |
| * | | | compute: Add '--no-network', '--auto-network' flagsStephen Finucane2022-10-262-38/+130
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | These are aliases for '--nic none' and '--nic auto', respectively. Change-Id: I7b4f7e5c3769a813bd8b2b9cd6090c6fe501e13d Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "quota: Deprecate "force" behavior for network quotas"Zuul2022-11-053-16/+46
|\ \ \ \
| * | | | quota: Deprecate "force" behavior for network quotasStephen Finucane2022-10-113-16/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In change Idc1b99492d609eb699d0a6bef6cd760458a774f6, we added a '--check-limit' option to enable "no force" behavior for network quotas. This was already the default for compute quotas. Provide a path for harmonizing the behavior of the two options by instead using a '--no-force' option which will become the eventual default for the network quotas also. Change-Id: I25828a3d68e2e900f498e17a0d01fb70be77548e Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | | Merge "quota: Fix issues with delete quota command"Zuul2022-11-052-16/+17
|\ \ \ \ \
| * | | | | quota: Fix issues with delete quota commandStephen Finucane2022-10-112-16/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We were passing a project object rather than just the ID. Also correct a typo in the call to delete network quotas. Change-Id: I2292db7932ec01026f0e54014e3d02218792617a Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | | | Merge "tests: Remove unnecessary nesting of volume resources"Zuul2022-11-0534-2567/+2378
|\ \ \ \ \ \ | |/ / / / /
| * | | | | tests: Remove unnecessary nesting of volume resourcesStephen Finucane2022-09-3034-2567/+2378
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I210ce7534d161e89115e5cb96e42ab7f27170aa1 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | | | Merge "tests: Remove duplicate FakeImagev1Client"Zuul2022-11-051-7/+4
|\ \ \ \ \ \ | |/ / / / /
| * | | | | tests: Remove duplicate FakeImagev1ClientStephen Finucane2022-09-301-7/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I guess this was defined to avoid a circular import. There are easier ways to do this. Change-Id: Iab215a53691298413ea9d10def792008ab9edbce Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | | | Merge "tests: Move fake clients to top of file"Zuul2022-11-053-123/+123
|\ \ \ \ \ \ | |/ / / / /
| * | | | | tests: Move fake clients to top of fileStephen Finucane2022-09-303-123/+123
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These are important and they're easier to identify at the top of the file than nested deep inside. Change-Id: I1569c855fadfe4cdacf83ee07d08922bf3edefbc Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | | Merge "quota: Trivial style fixups"Zuul2022-11-051-38/+40
|\ \ \ \ \ | |/ / / /
| * | | | quota: Trivial style fixupsStephen Finucane2022-09-301-38/+40
| | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I4522b54676033dced2b47477238ceb551e11d04a Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | | Merge "quota: Deprecate 'quota show --class', 'quota set --class' arguments"Zuul2022-11-051-4/+36
|\ \ \ \ \ | |/ / / /
| * | | | quota: Deprecate 'quota show --class', 'quota set --class' argumentsStephen Finucane2022-09-301-4/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This doesn't do anything special in nova and cinder and is not supported in neutron. For the 'quota show' command, people should use the '--default' argument instead. Change-Id: I0dd38e5cb252a01d5817ed168be040b21b35e348 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | | Merge "quota: Allow showing project-specific quotas"Zuul2022-11-052-26/+129
|\ \ \ \ \ | |/ / / / | | | | / | |_|_|/ |/| | |
| * | | quota: Allow showing project-specific quotasStephen Finucane2022-09-302-26/+129
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add '--compute', '--network' and '--volume' options to the 'quota show' command, along with a default '--all' option, allowing us to restrict quotas shown to an individual service. Change-Id: I122b765df01887b8d916ee6567ffb7768fcb4392 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "Added "openstack image metadefs namespace list" command"Zuul2022-10-263-0/+186
|\ \ \ \
| * | | | Added "openstack image metadefs namespace list" commandAreg Grigoryan2022-10-263-0/+186
| | |/ / | |/| | | | | | | | | | | | | | Change-Id: Ibc064566478818bd70e7e6550095d24a05e1bb0e Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/854612
* | | | Merge "volume: Volume names are optional"Zuul2022-10-262-4/+3
|\ \ \ \ | |/ / / |/| | |
| * | | volume: Volume names are optionalStephen Finucane2022-09-142-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Who knew? Change-Id: I1c1a811c0db59250e8a20a87f25c2662bc3ab3e8 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "quota: Add 'quota show --usage' option"Zuul2022-10-123-30/+133
|\ \ \ \ | | |/ / | |/| |
View Lorry Controller Status