summaryrefslogtreecommitdiff
path: root/troveclient/tests/test_secgroups.py
Commit message (Collapse)AuthorAgeFilesLines
* Use unittest.mock instead of third party mockSean McGinnis2020-04-181-1/+1
| | | | | | | | Now that we no longer support py27, we can use the standard library unittest.mock module instead of the third party mock lib. Change-Id: Ib83e626f51e6e01898bb7931c1660a1a548500f3 Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
* Added more unit-tests to improve code coverageSushil Kumar2015-06-081-9/+5
| | | | | | | | | | | | | | | | | Following files were too low on code coverage, so the coverage has been enhanced with addition of more unit-tests. - troveclient/client.py - troveclient/v1/shell.py The methodology to test shell.py has been motivated from the one used by python-novaclient to test novaclient/v2/shell.py Also, found an unmocked entry in test_secgroups.py, which was causing intermittent failure while writing the tests for shell.py. Closes-Bug: #1455856 Change-Id: I6a148fb5caad6a83b6ac23411b6458f231064ead
* Enabled F821, H306, H402, and H404 flake8 ruleSushil Kumar2014-05-091-1/+1
| | | | | | | | | | | | | | Reasons: - F821 is disabled. - H306 is disabled. - H402 is disabled. - H404 is disabled. Changes: - Updates tox.ini to enable F821, H306, H402 and H404 rules. - Updates code for F821, H306, H402 and H404 violation. Change-Id: I772270bb833ac774e080fc63e330d6b333f23de2
* Fix create call for security group rulesDenis Makogon2014-04-011-13/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reasons: - The security group rule create call was expecting from_port, to_port, and protocol as arguments, but the Trove API was ignoring these since it picks these up from the respective datastore confs. Changes: - Removing the extra arguments from the security-group-rule create command: - from_port - to_port - protocol Note that even though the user was able to specify the ports for the rule these were _never_ being honored since these were being picked up from the respective config files. Usage before change: - trove secgroup-add-rule <security_group> <protocol> <from_port> <to_port> <cidr> Usage after change: - trove secgroup-add-rule <security_group> <cidr> Change-Id: Ic1440f735b6cf2b8b4f29c5ab9f48bcb427ca9e6 Closes-Bug: #1298749
* Remove vim headerHe Yongli2014-02-161-2/+0
| | | | | | | | | | | No need to set tabstop tons of times, this can be set in your vimrc file instead. More disucssion: http://openstack.10931.n7.nabble.com/Remove-vim-modelines-td21780.html Change-Id: I45766d91f0c0b3622bbdc7dc5517497c87ebee8c Closes-Bug: #1229324
* Ignore fewer PEP8/flake8 rulesDenis Makogon2013-12-101-15/+22
| | | | | | | | | | | | Reasons: - code should be pythonicaly clean, that is why number of ignored rules should reduced Changes: - E125, F811, H102, H103, F201, H23, H302, F841, H301, H702, H703 rules are now enabled Change-Id: Ibf4025162244d3c2f1278b49a76ec1527a729042
* Fixing copyright and license headersMichael Basnight2013-10-221-0/+19
| | | | | | * Added HP copyrights as appropriate Change-Id: If4f30b0caf03b16f5fb4f54185ba80d9fa41d0b0
* Massive refactoring to the troveclientMichael Basnight2013-10-091-2/+2
| | | | | | | | | | | | | | | | The new client adheres to the standards of the other clients now. It prints out tables, uses ENVVAR's for auth, no longer stores pickled json in a login token, uses openstack common, and moves the cli operations into a v1 module for the future of trove when it has a v2 api. Please note for compatibility, the troveclient.compat module has the old cli. In order to deploy it, amend the setup.cfg to include the compat module. implements blueprint cli-compliance-upgrade Change-Id: Ie69d9dbc75ce90496da316244c97acca1877a327
* Start using pyflakesDirk Mueller2013-06-261-1/+0
| | | | | | | | Instead of globally disabling pyflakes warnings, disable only those that occur frequently and fix the rest. Enable gating on those. Change-Id: I774d809ebcda2339b30c104b031211a3b2c491bd
* Rename from reddwarf to trove.0.1.3Michael Basnight2013-06-211-0/+102
Implements Blueprint reddwarf-trove-rename Change-Id: Ib2d694c7466887ca297bea4250eca17cdc06b7bf