summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStanislav Malyshev <stas@php.net>2013-02-26 22:13:01 -0800
committerStanislav Malyshev <stas@php.net>2013-02-26 22:13:01 -0800
commit207d0ee08abcfba2d8da3bca343c4879710985b9 (patch)
tree343a8dbbcdf10efccf0860dd8f086128d34f2bb8
parent7a3933a93ba2f0b1f9245d0b195bfec54951fca4 (diff)
parent7c082325091ee7bfcf0e1e8b488b1e9fa66f0739 (diff)
downloadphp-git-207d0ee08abcfba2d8da3bca343c4879710985b9.tar.gz
Merge branch 'PHP-5.4' into PHP-5.5
* PHP-5.4: Bug #52861: unset fails with ArrayObject and deep arrays
-rw-r--r--ext/spl/spl_array.c2
-rw-r--r--ext/spl/tests/bug52861.phpt22
2 files changed, 23 insertions, 1 deletions
diff --git a/ext/spl/spl_array.c b/ext/spl/spl_array.c
index 20eb099284..e56a8f09e2 100644
--- a/ext/spl/spl_array.c
+++ b/ext/spl/spl_array.c
@@ -402,7 +402,7 @@ static zval *spl_array_read_dimension_ex(int check_inherited, zval *object, zval
/* When in a write context,
* ZE has to be fooled into thinking this is in a reference set
* by separating (if necessary) and returning as an is_ref=1 zval (even if refcount == 1) */
- if ((type == BP_VAR_W || type == BP_VAR_RW) && !Z_ISREF_PP(ret)) {
+ if ((type == BP_VAR_W || type == BP_VAR_RW || type == BP_VAR_UNSET) && !Z_ISREF_PP(ret)) {
if (Z_REFCOUNT_PP(ret) > 1) {
zval *newval;
diff --git a/ext/spl/tests/bug52861.phpt b/ext/spl/tests/bug52861.phpt
new file mode 100644
index 0000000000..30a3261c4e
--- /dev/null
+++ b/ext/spl/tests/bug52861.phpt
@@ -0,0 +1,22 @@
+--TEST--
+Bug #52861 (unset failes with ArrayObject and deep arrays)
+--FILE--
+<?php
+$arrayObject = new ArrayObject(array('foo' => array('bar' => array('baz' => 'boo'))));
+
+unset($arrayObject['foo']['bar']['baz']);
+print_r($arrayObject->getArrayCopy());
+?>
+--EXPECT--
+Array
+(
+ [foo] => Array
+ (
+ [bar] => Array
+ (
+ )
+
+ )
+
+)
+