diff options
author | Anatol Belski <ab@php.net> | 2017-07-04 10:44:50 +0200 |
---|---|---|
committer | Anatol Belski <ab@php.net> | 2017-07-04 10:44:50 +0200 |
commit | b28c6515a638ae7372bfbddd1a63fccdd1b04733 (patch) | |
tree | 9ec82b54666f7bce6104b3e44406349a6afb110a | |
parent | 10dbc0b2e79a5e3c36a0cb681c8db2c529e8f6f8 (diff) | |
parent | 2dc24005d9fe1827705276cec52397a57ae66549 (diff) | |
download | php-git-b28c6515a638ae7372bfbddd1a63fccdd1b04733.tar.gz |
Merge branch 'PHP-7.1'
* PHP-7.1:
Fixed bug #74101 and bug #74614
-rw-r--r-- | ext/standard/tests/serialize/bug74101.phpt | 10 | ||||
-rw-r--r-- | ext/standard/tests/serialize/bug74614.phpt | 10 | ||||
-rw-r--r-- | ext/standard/var_unserializer.c | 880 | ||||
-rw-r--r-- | ext/standard/var_unserializer.re | 8 |
4 files changed, 481 insertions, 427 deletions
diff --git a/ext/standard/tests/serialize/bug74101.phpt b/ext/standard/tests/serialize/bug74101.phpt new file mode 100644 index 0000000000..a414060f5c --- /dev/null +++ b/ext/standard/tests/serialize/bug74101.phpt @@ -0,0 +1,10 @@ +--TEST-- +Bug #74101: Unserialize Heap Use-After-Free (READ: 1) in zval_get_type +--FILE-- +<?php +$s = 'O:9:"Exception":799999999999999999999999999997:0i:0;a:0:{}i:2;i:0;i:0;R:2;'; +var_dump(unserialize($s)); +?> +--EXPECTF-- +Notice: unserialize(): Error at offset 48 of 74 bytes in %s on line %d +bool(false) diff --git a/ext/standard/tests/serialize/bug74614.phpt b/ext/standard/tests/serialize/bug74614.phpt new file mode 100644 index 0000000000..ae962628e9 --- /dev/null +++ b/ext/standard/tests/serialize/bug74614.phpt @@ -0,0 +1,10 @@ +--TEST-- +Bug #74614: Use-after-free in PHP7's unserialize() +--FILE-- +<?php + +unserialize('a:3020000000000000000000000000000001:{i:0;a:0:{}i:1;i:2;i:2;i:3;i:3;i:4;i:4;i:5;i:5;i:6;i:6;i:7;i:7;i:8;i:8;R:2;}'); + +?> +--EXPECTF-- +Notice: unserialize(): Error at offset 38 of 113 bytes in %s on line %d diff --git a/ext/standard/var_unserializer.c b/ext/standard/var_unserializer.c index b480bb2ee3..4a3380dd95 100644 --- a/ext/standard/var_unserializer.c +++ b/ext/standard/var_unserializer.c @@ -1,4 +1,4 @@ -/* Generated by re2c 0.14.3 */ +/* Generated by re2c 0.16 */ #line 1 "ext/standard/var_unserializer.re" /* +----------------------------------------------------------------------+ @@ -545,6 +545,10 @@ static inline int object_common2(UNSERIALIZE_PARAMETER, zend_long elements) && zend_hash_str_exists(&Z_OBJCE_P(rval)->function_table, "__wakeup", sizeof("__wakeup")-1); ht = Z_OBJPROP_P(rval); + if (elements >= HT_MAX_SIZE - zend_hash_num_elements(ht)) { + return 0; + } + zend_hash_extend(ht, zend_hash_num_elements(ht) + elements, (ht->u.flags & HASH_FLAG_PACKED)); if (!process_nested_data(UNSERIALIZE_PASSTHRU, ht, elements, 1)) { if (has_wakeup) { @@ -614,7 +618,7 @@ static int php_var_unserialize_internal(UNSERIALIZE_PARAMETER) start = cursor; -#line 618 "ext/standard/var_unserializer.c" +#line 622 "ext/standard/var_unserializer.c" { YYCTYPE yych; static const unsigned char yybm[] = { @@ -651,105 +655,458 @@ static int php_var_unserialize_internal(UNSERIALIZE_PARAMETER) 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, }; - if ((YYLIMIT - YYCURSOR) < 7) YYFILL(7); yych = *YYCURSOR; switch (yych) { case 'C': - case 'O': goto yy13; + case 'O': goto yy4; case 'N': goto yy5; - case 'R': goto yy2; - case 'S': goto yy10; - case 'a': goto yy11; - case 'b': goto yy6; - case 'd': goto yy8; - case 'i': goto yy7; + case 'R': goto yy6; + case 'S': goto yy7; + case 'a': goto yy8; + case 'b': goto yy9; + case 'd': goto yy10; + case 'i': goto yy11; case 'o': goto yy12; - case 'r': goto yy4; - case 's': goto yy9; - case '}': goto yy14; - default: goto yy16; + case 'r': goto yy13; + case 's': goto yy14; + case '}': goto yy15; + default: goto yy2; } yy2: - yych = *(YYMARKER = ++YYCURSOR); - if (yych == ':') goto yy88; + ++YYCURSOR; yy3: -#line 1007 "ext/standard/var_unserializer.re" +#line 1011 "ext/standard/var_unserializer.re" { return 0; } -#line 680 "ext/standard/var_unserializer.c" +#line 682 "ext/standard/var_unserializer.c" yy4: yych = *(YYMARKER = ++YYCURSOR); - if (yych == ':') goto yy83; + if (yych == ':') goto yy17; goto yy3; yy5: yych = *++YYCURSOR; - if (yych == ';') goto yy81; + if (yych == ';') goto yy19; goto yy3; yy6: yych = *(YYMARKER = ++YYCURSOR); - if (yych == ':') goto yy77; + if (yych == ':') goto yy21; goto yy3; yy7: yych = *(YYMARKER = ++YYCURSOR); - if (yych == ':') goto yy71; + if (yych == ':') goto yy22; goto yy3; yy8: yych = *(YYMARKER = ++YYCURSOR); - if (yych == ':') goto yy48; + if (yych == ':') goto yy23; goto yy3; yy9: yych = *(YYMARKER = ++YYCURSOR); - if (yych == ':') goto yy42; + if (yych == ':') goto yy24; goto yy3; yy10: yych = *(YYMARKER = ++YYCURSOR); - if (yych == ':') goto yy36; + if (yych == ':') goto yy25; goto yy3; yy11: yych = *(YYMARKER = ++YYCURSOR); - if (yych == ':') goto yy30; + if (yych == ':') goto yy26; goto yy3; yy12: yych = *(YYMARKER = ++YYCURSOR); - if (yych == ':') goto yy24; + if (yych == ':') goto yy27; goto yy3; yy13: yych = *(YYMARKER = ++YYCURSOR); - if (yych == ':') goto yy17; + if (yych == ':') goto yy28; goto yy3; yy14: + yych = *(YYMARKER = ++YYCURSOR); + if (yych == ':') goto yy29; + goto yy3; +yy15: ++YYCURSOR; -#line 1001 "ext/standard/var_unserializer.re" +#line 1005 "ext/standard/var_unserializer.re" { /* this is the case where we have less data than planned */ php_error_docref(NULL, E_NOTICE, "Unexpected end of serialized data"); return 0; /* not sure if it should be 0 or 1 here? */ } -#line 729 "ext/standard/var_unserializer.c" -yy16: - yych = *++YYCURSOR; - goto yy3; +#line 735 "ext/standard/var_unserializer.c" yy17: yych = *++YYCURSOR; if (yybm[0+yych] & 128) { - goto yy19; + goto yy30; } yy18: YYCURSOR = YYMARKER; goto yy3; yy19: ++YYCURSOR; +#line 677 "ext/standard/var_unserializer.re" + { + *p = YYCURSOR; + ZVAL_NULL(rval); + return 1; +} +#line 752 "ext/standard/var_unserializer.c" +yy21: + yych = *++YYCURSOR; + if (yych <= '/') goto yy18; + if (yych <= '9') goto yy32; + goto yy18; +yy22: + yych = *++YYCURSOR; + if (yych <= '/') goto yy18; + if (yych <= '9') goto yy34; + goto yy18; +yy23: + yych = *++YYCURSOR; + if (yych <= '/') goto yy18; + if (yych <= '9') goto yy36; + goto yy18; +yy24: + yych = *++YYCURSOR; + if (yych <= '/') goto yy18; + if (yych <= '1') goto yy38; + goto yy18; +yy25: + yych = *++YYCURSOR; + if (yych <= '/') { + if (yych <= ',') { + if (yych == '+') goto yy39; + goto yy18; + } else { + if (yych <= '-') goto yy40; + if (yych <= '.') goto yy41; + goto yy18; + } + } else { + if (yych <= 'I') { + if (yych <= '9') goto yy42; + if (yych <= 'H') goto yy18; + goto yy44; + } else { + if (yych == 'N') goto yy45; + goto yy18; + } + } +yy26: + yych = *++YYCURSOR; + if (yych <= ',') { + if (yych == '+') goto yy46; + goto yy18; + } else { + if (yych <= '-') goto yy46; + if (yych <= '/') goto yy18; + if (yych <= '9') goto yy47; + goto yy18; + } +yy27: + yych = *++YYCURSOR; + if (yych <= '/') goto yy18; + if (yych <= '9') goto yy49; + goto yy18; +yy28: + yych = *++YYCURSOR; + if (yych <= '/') goto yy18; + if (yych <= '9') goto yy51; + goto yy18; +yy29: + yych = *++YYCURSOR; + if (yych <= '/') goto yy18; + if (yych <= '9') goto yy53; + goto yy18; +yy30: + ++YYCURSOR; if ((YYLIMIT - YYCURSOR) < 2) YYFILL(2); yych = *YYCURSOR; if (yybm[0+yych] & 128) { - goto yy19; + goto yy30; } if (yych <= '/') goto yy18; - if (yych >= ';') goto yy18; + if (yych <= ':') goto yy55; + goto yy18; +yy32: + ++YYCURSOR; + if (YYLIMIT <= YYCURSOR) YYFILL(1); + yych = *YYCURSOR; + if (yych <= '/') goto yy18; + if (yych <= '9') goto yy32; + if (yych == ';') goto yy56; + goto yy18; +yy34: + ++YYCURSOR; + if ((YYLIMIT - YYCURSOR) < 2) YYFILL(2); + yych = *YYCURSOR; + if (yych <= '/') goto yy18; + if (yych <= '9') goto yy34; + if (yych <= ':') goto yy58; + goto yy18; +yy36: + ++YYCURSOR; + if ((YYLIMIT - YYCURSOR) < 2) YYFILL(2); + yych = *YYCURSOR; + if (yych <= '/') goto yy18; + if (yych <= '9') goto yy36; + if (yych <= ':') goto yy59; + goto yy18; +yy38: + yych = *++YYCURSOR; + if (yych == ';') goto yy60; + goto yy18; +yy39: + yych = *++YYCURSOR; + if (yych == '.') goto yy41; + if (yych <= '/') goto yy18; + if (yych <= '9') goto yy42; + goto yy18; +yy40: + yych = *++YYCURSOR; + if (yych <= '/') { + if (yych != '.') goto yy18; + } else { + if (yych <= '9') goto yy42; + if (yych == 'I') goto yy44; + goto yy18; + } +yy41: + yych = *++YYCURSOR; + if (yych <= '/') goto yy18; + if (yych <= '9') goto yy62; + goto yy18; +yy42: + ++YYCURSOR; + if ((YYLIMIT - YYCURSOR) < 3) YYFILL(3); + yych = *YYCURSOR; + if (yych <= ':') { + if (yych <= '.') { + if (yych <= '-') goto yy18; + goto yy62; + } else { + if (yych <= '/') goto yy18; + if (yych <= '9') goto yy42; + goto yy18; + } + } else { + if (yych <= 'E') { + if (yych <= ';') goto yy64; + if (yych <= 'D') goto yy18; + goto yy66; + } else { + if (yych == 'e') goto yy66; + goto yy18; + } + } +yy44: + yych = *++YYCURSOR; + if (yych == 'N') goto yy67; + goto yy18; +yy45: + yych = *++YYCURSOR; + if (yych == 'A') goto yy68; + goto yy18; +yy46: + yych = *++YYCURSOR; + if (yych <= '/') goto yy18; + if (yych >= ':') goto yy18; +yy47: + ++YYCURSOR; + if (YYLIMIT <= YYCURSOR) YYFILL(1); + yych = *YYCURSOR; + if (yych <= '/') goto yy18; + if (yych <= '9') goto yy47; + if (yych == ';') goto yy69; + goto yy18; +yy49: + ++YYCURSOR; + if ((YYLIMIT - YYCURSOR) < 2) YYFILL(2); + yych = *YYCURSOR; + if (yych <= '/') goto yy18; + if (yych <= '9') goto yy49; + if (yych <= ':') goto yy71; + goto yy18; +yy51: + ++YYCURSOR; + if (YYLIMIT <= YYCURSOR) YYFILL(1); + yych = *YYCURSOR; + if (yych <= '/') goto yy18; + if (yych <= '9') goto yy51; + if (yych == ';') goto yy72; + goto yy18; +yy53: + ++YYCURSOR; + if ((YYLIMIT - YYCURSOR) < 2) YYFILL(2); + yych = *YYCURSOR; + if (yych <= '/') goto yy18; + if (yych <= '9') goto yy53; + if (yych <= ':') goto yy74; + goto yy18; +yy55: + yych = *++YYCURSOR; + if (yych == '"') goto yy75; + goto yy18; +yy56: + ++YYCURSOR; +#line 626 "ext/standard/var_unserializer.re" + { + zend_long id; + + *p = YYCURSOR; + if (!var_hash) return 0; + + id = parse_uiv(start + 2) - 1; + if (id == -1 || (rval_ref = var_access(var_hash, id)) == NULL) { + return 0; + } + + zval_ptr_dtor(rval); + if (Z_ISUNDEF_P(rval_ref) || (Z_ISREF_P(rval_ref) && Z_ISUNDEF_P(Z_REFVAL_P(rval_ref)))) { + ZVAL_UNDEF(rval); + return 1; + } + if (Z_ISREF_P(rval_ref)) { + ZVAL_COPY(rval, rval_ref); + } else { + ZVAL_NEW_REF(rval_ref, rval_ref); + ZVAL_COPY(rval, rval_ref); + } + + return 1; +} +#line 977 "ext/standard/var_unserializer.c" +yy58: + yych = *++YYCURSOR; + if (yych == '"') goto yy77; + goto yy18; +yy59: + yych = *++YYCURSOR; + if (yych == '{') goto yy79; + goto yy18; +yy60: + ++YYCURSOR; +#line 683 "ext/standard/var_unserializer.re" + { + *p = YYCURSOR; + ZVAL_BOOL(rval, parse_iv(start + 2)); + return 1; +} +#line 994 "ext/standard/var_unserializer.c" +yy62: + ++YYCURSOR; + if ((YYLIMIT - YYCURSOR) < 3) YYFILL(3); + yych = *YYCURSOR; + if (yych <= ';') { + if (yych <= '/') goto yy18; + if (yych <= '9') goto yy62; + if (yych <= ':') goto yy18; + } else { + if (yych <= 'E') { + if (yych <= 'D') goto yy18; + goto yy66; + } else { + if (yych == 'e') goto yy66; + goto yy18; + } + } +yy64: + ++YYCURSOR; +#line 731 "ext/standard/var_unserializer.re" + { +#if SIZEOF_ZEND_LONG == 4 +use_double: +#endif + *p = YYCURSOR; + ZVAL_DOUBLE(rval, zend_strtod((const char *)start + 2, NULL)); + return 1; +} +#line 1023 "ext/standard/var_unserializer.c" +yy66: yych = *++YYCURSOR; - if (yych != '"') goto yy18; + if (yych <= ',') { + if (yych == '+') goto yy81; + goto yy18; + } else { + if (yych <= '-') goto yy81; + if (yych <= '/') goto yy18; + if (yych <= '9') goto yy82; + goto yy18; + } +yy67: + yych = *++YYCURSOR; + if (yych == 'F') goto yy84; + goto yy18; +yy68: + yych = *++YYCURSOR; + if (yych == 'N') goto yy84; + goto yy18; +yy69: ++YYCURSOR; -#line 849 "ext/standard/var_unserializer.re" +#line 689 "ext/standard/var_unserializer.re" + { +#if SIZEOF_ZEND_LONG == 4 + int digits = YYCURSOR - start - 3; + + if (start[2] == '-' || start[2] == '+') { + digits--; + } + + /* Use double for large zend_long values that were serialized on a 64-bit system */ + if (digits >= MAX_LENGTH_OF_LONG - 1) { + if (digits == MAX_LENGTH_OF_LONG - 1) { + int cmp = strncmp((char*)YYCURSOR - MAX_LENGTH_OF_LONG, long_min_digits, MAX_LENGTH_OF_LONG - 1); + + if (!(cmp < 0 || (cmp == 0 && start[2] == '-'))) { + goto use_double; + } + } else { + goto use_double; + } + } +#endif + *p = YYCURSOR; + ZVAL_LONG(rval, parse_iv(start + 2)); + return 1; +} +#line 1071 "ext/standard/var_unserializer.c" +yy71: + yych = *++YYCURSOR; + if (yych == '"') goto yy85; + goto yy18; +yy72: + ++YYCURSOR; +#line 652 "ext/standard/var_unserializer.re" + { + zend_long id; + + *p = YYCURSOR; + if (!var_hash) return 0; + + id = parse_uiv(start + 2) - 1; + if (id == -1 || (rval_ref = var_access(var_hash, id)) == NULL) { + return 0; + } + + if (rval_ref == rval) { + return 0; + } + + if (Z_ISUNDEF_P(rval_ref) || (Z_ISREF_P(rval_ref) && Z_ISUNDEF_P(Z_REFVAL_P(rval_ref)))) { + ZVAL_UNDEF(rval); + return 1; + } + + ZVAL_COPY(rval, rval_ref); + + return 1; +} +#line 1103 "ext/standard/var_unserializer.c" +yy74: + yych = *++YYCURSOR; + if (yych == '"') goto yy87; + goto yy18; +yy75: + ++YYCURSOR; +#line 853 "ext/standard/var_unserializer.re" { size_t len, len2, len3, maxlen; zend_long elements; @@ -901,55 +1258,54 @@ yy19: return object_common2(UNSERIALIZE_PASSTHRU, elements); } -#line 905 "ext/standard/var_unserializer.c" -yy24: - yych = *++YYCURSOR; - if (yych <= '/') goto yy18; - if (yych >= ':') goto yy18; -yy25: - ++YYCURSOR; - if ((YYLIMIT - YYCURSOR) < 2) YYFILL(2); - yych = *YYCURSOR; - if (yych <= '/') goto yy18; - if (yych <= '9') goto yy25; - if (yych >= ';') goto yy18; - yych = *++YYCURSOR; - if (yych != '"') goto yy18; +#line 1262 "ext/standard/var_unserializer.c" +yy77: ++YYCURSOR; -#line 838 "ext/standard/var_unserializer.re" +#line 778 "ext/standard/var_unserializer.re" { - long elements; - if (!var_hash) return 0; + size_t len, maxlen; + zend_string *str; - elements = object_common1(UNSERIALIZE_PASSTHRU, ZEND_STANDARD_CLASS_DEF_PTR); - if (elements < 0) { + len = parse_uiv(start + 2); + maxlen = max - YYCURSOR; + if (maxlen < len) { + *p = start + 2; return 0; } - return object_common2(UNSERIALIZE_PASSTHRU, elements); + + if ((str = unserialize_str(&YYCURSOR, len, maxlen)) == NULL) { + return 0; + } + + if (*(YYCURSOR) != '"') { + zend_string_free(str); + *p = YYCURSOR; + return 0; + } + + if (*(YYCURSOR + 1) != ';') { + efree(str); + *p = YYCURSOR + 1; + return 0; + } + + YYCURSOR += 2; + *p = YYCURSOR; + + ZVAL_STR(rval, str); + return 1; } -#line 931 "ext/standard/var_unserializer.c" -yy30: - yych = *++YYCURSOR; - if (yych <= '/') goto yy18; - if (yych >= ':') goto yy18; -yy31: +#line 1299 "ext/standard/var_unserializer.c" +yy79: ++YYCURSOR; - if ((YYLIMIT - YYCURSOR) < 2) YYFILL(2); - yych = *YYCURSOR; - if (yych <= '/') goto yy18; - if (yych <= '9') goto yy31; - if (yych >= ';') goto yy18; - yych = *++YYCURSOR; - if (yych != '{') goto yy18; - ++YYCURSOR; -#line 808 "ext/standard/var_unserializer.re" +#line 812 "ext/standard/var_unserializer.re" { zend_long elements = parse_iv(start + 2); /* use iv() not uiv() in order to check data range */ *p = YYCURSOR; if (!var_hash) return 0; - if (elements < 0) { + if (elements < 0 || elements >= HT_MAX_SIZE) { return 0; } @@ -972,71 +1328,40 @@ yy31: return finish_nested_data(UNSERIALIZE_PASSTHRU); } -#line 976 "ext/standard/var_unserializer.c" -yy36: +#line 1332 "ext/standard/var_unserializer.c" +yy81: yych = *++YYCURSOR; if (yych <= '/') goto yy18; if (yych >= ':') goto yy18; -yy37: +yy82: ++YYCURSOR; - if ((YYLIMIT - YYCURSOR) < 2) YYFILL(2); + if (YYLIMIT <= YYCURSOR) YYFILL(1); yych = *YYCURSOR; if (yych <= '/') goto yy18; - if (yych <= '9') goto yy37; - if (yych >= ';') goto yy18; + if (yych <= '9') goto yy82; + if (yych == ';') goto yy64; + goto yy18; +yy84: yych = *++YYCURSOR; - if (yych != '"') goto yy18; + if (yych == ';') goto yy89; + goto yy18; +yy85: ++YYCURSOR; -#line 774 "ext/standard/var_unserializer.re" +#line 842 "ext/standard/var_unserializer.re" { - size_t len, maxlen; - zend_string *str; - - len = parse_uiv(start + 2); - maxlen = max - YYCURSOR; - if (maxlen < len) { - *p = start + 2; - return 0; - } - - if ((str = unserialize_str(&YYCURSOR, len, maxlen)) == NULL) { - return 0; - } - - if (*(YYCURSOR) != '"') { - zend_string_free(str); - *p = YYCURSOR; - return 0; - } + long elements; + if (!var_hash) return 0; - if (*(YYCURSOR + 1) != ';') { - efree(str); - *p = YYCURSOR + 1; + elements = object_common1(UNSERIALIZE_PASSTHRU, ZEND_STANDARD_CLASS_DEF_PTR); + if (elements < 0 || elements >= HT_MAX_SIZE) { return 0; } - - YYCURSOR += 2; - *p = YYCURSOR; - - ZVAL_STR(rval, str); - return 1; + return object_common2(UNSERIALIZE_PASSTHRU, elements); } -#line 1025 "ext/standard/var_unserializer.c" -yy42: - yych = *++YYCURSOR; - if (yych <= '/') goto yy18; - if (yych >= ':') goto yy18; -yy43: +#line 1362 "ext/standard/var_unserializer.c" +yy87: ++YYCURSOR; - if ((YYLIMIT - YYCURSOR) < 2) YYFILL(2); - yych = *YYCURSOR; - if (yych <= '/') goto yy18; - if (yych <= '9') goto yy43; - if (yych >= ';') goto yy18; - yych = *++YYCURSOR; - if (yych != '"') goto yy18; - ++YYCURSOR; -#line 736 "ext/standard/var_unserializer.re" +#line 740 "ext/standard/var_unserializer.re" { size_t len, maxlen; char *str; @@ -1074,152 +1399,10 @@ yy43: } return 1; } -#line 1078 "ext/standard/var_unserializer.c" -yy48: - yych = *++YYCURSOR; - if (yych <= '/') { - if (yych <= ',') { - if (yych == '+') goto yy52; - goto yy18; - } else { - if (yych <= '-') goto yy50; - if (yych <= '.') goto yy55; - goto yy18; - } - } else { - if (yych <= 'I') { - if (yych <= '9') goto yy53; - if (yych <= 'H') goto yy18; - goto yy51; - } else { - if (yych != 'N') goto yy18; - } - } - yych = *++YYCURSOR; - if (yych == 'A') goto yy70; - goto yy18; -yy50: - yych = *++YYCURSOR; - if (yych <= '/') { - if (yych == '.') goto yy55; - goto yy18; - } else { - if (yych <= '9') goto yy53; - if (yych != 'I') goto yy18; - } -yy51: - yych = *++YYCURSOR; - if (yych == 'N') goto yy66; - goto yy18; -yy52: - yych = *++YYCURSOR; - if (yych == '.') goto yy55; - if (yych <= '/') goto yy18; - if (yych >= ':') goto yy18; -yy53: - ++YYCURSOR; - if ((YYLIMIT - YYCURSOR) < 3) YYFILL(3); - yych = *YYCURSOR; - if (yych <= ':') { - if (yych <= '.') { - if (yych <= '-') goto yy18; - goto yy64; - } else { - if (yych <= '/') goto yy18; - if (yych <= '9') goto yy53; - goto yy18; - } - } else { - if (yych <= 'E') { - if (yych <= ';') goto yy58; - if (yych <= 'D') goto yy18; - goto yy60; - } else { - if (yych == 'e') goto yy60; - goto yy18; - } - } -yy55: - yych = *++YYCURSOR; - if (yych <= '/') goto yy18; - if (yych >= ':') goto yy18; -yy56: - ++YYCURSOR; - if ((YYLIMIT - YYCURSOR) < 3) YYFILL(3); - yych = *YYCURSOR; - if (yych <= ';') { - if (yych <= '/') goto yy18; - if (yych <= '9') goto yy56; - if (yych <= ':') goto yy18; - } else { - if (yych <= 'E') { - if (yych <= 'D') goto yy18; - goto yy60; - } else { - if (yych == 'e') goto yy60; - goto yy18; - } - } -yy58: - ++YYCURSOR; -#line 727 "ext/standard/var_unserializer.re" - { -#if SIZEOF_ZEND_LONG == 4 -use_double: -#endif - *p = YYCURSOR; - ZVAL_DOUBLE(rval, zend_strtod((const char *)start + 2, NULL)); - return 1; -} -#line 1175 "ext/standard/var_unserializer.c" -yy60: - yych = *++YYCURSOR; - if (yych <= ',') { - if (yych != '+') goto yy18; - } else { - if (yych <= '-') goto yy61; - if (yych <= '/') goto yy18; - if (yych <= '9') goto yy62; - goto yy18; - } -yy61: - yych = *++YYCURSOR; - if (yych <= '/') goto yy18; - if (yych >= ':') goto yy18; -yy62: - ++YYCURSOR; - if (YYLIMIT <= YYCURSOR) YYFILL(1); - yych = *YYCURSOR; - if (yych <= '/') goto yy18; - if (yych <= '9') goto yy62; - if (yych == ';') goto yy58; - goto yy18; -yy64: - ++YYCURSOR; - if ((YYLIMIT - YYCURSOR) < 3) YYFILL(3); - yych = *YYCURSOR; - if (yych <= ';') { - if (yych <= '/') goto yy18; - if (yych <= '9') goto yy64; - if (yych <= ':') goto yy18; - goto yy58; - } else { - if (yych <= 'E') { - if (yych <= 'D') goto yy18; - goto yy60; - } else { - if (yych == 'e') goto yy60; - goto yy18; - } - } -yy66: - yych = *++YYCURSOR; - if (yych != 'F') goto yy18; -yy67: - yych = *++YYCURSOR; - if (yych != ';') goto yy18; +#line 1403 "ext/standard/var_unserializer.c" +yy89: ++YYCURSOR; -#line 711 "ext/standard/var_unserializer.re" +#line 715 "ext/standard/var_unserializer.re" { *p = YYCURSOR; @@ -1235,162 +1418,9 @@ yy67: return 1; } -#line 1239 "ext/standard/var_unserializer.c" -yy70: - yych = *++YYCURSOR; - if (yych == 'N') goto yy67; - goto yy18; -yy71: - yych = *++YYCURSOR; - if (yych <= ',') { - if (yych != '+') goto yy18; - } else { - if (yych <= '-') goto yy72; - if (yych <= '/') goto yy18; - if (yych <= '9') goto yy73; - goto yy18; - } -yy72: - yych = *++YYCURSOR; - if (yych <= '/') goto yy18; - if (yych >= ':') goto yy18; -yy73: - ++YYCURSOR; - if (YYLIMIT <= YYCURSOR) YYFILL(1); - yych = *YYCURSOR; - if (yych <= '/') goto yy18; - if (yych <= '9') goto yy73; - if (yych != ';') goto yy18; - ++YYCURSOR; -#line 685 "ext/standard/var_unserializer.re" - { -#if SIZEOF_ZEND_LONG == 4 - int digits = YYCURSOR - start - 3; - - if (start[2] == '-' || start[2] == '+') { - digits--; - } - - /* Use double for large zend_long values that were serialized on a 64-bit system */ - if (digits >= MAX_LENGTH_OF_LONG - 1) { - if (digits == MAX_LENGTH_OF_LONG - 1) { - int cmp = strncmp((char*)YYCURSOR - MAX_LENGTH_OF_LONG, long_min_digits, MAX_LENGTH_OF_LONG - 1); - - if (!(cmp < 0 || (cmp == 0 && start[2] == '-'))) { - goto use_double; - } - } else { - goto use_double; - } - } -#endif - *p = YYCURSOR; - ZVAL_LONG(rval, parse_iv(start + 2)); - return 1; -} -#line 1292 "ext/standard/var_unserializer.c" -yy77: - yych = *++YYCURSOR; - if (yych <= '/') goto yy18; - if (yych >= '2') goto yy18; - yych = *++YYCURSOR; - if (yych != ';') goto yy18; - ++YYCURSOR; -#line 679 "ext/standard/var_unserializer.re" - { - *p = YYCURSOR; - ZVAL_BOOL(rval, parse_iv(start + 2)); - return 1; -} -#line 1306 "ext/standard/var_unserializer.c" -yy81: - ++YYCURSOR; -#line 673 "ext/standard/var_unserializer.re" - { - *p = YYCURSOR; - ZVAL_NULL(rval); - return 1; -} -#line 1315 "ext/standard/var_unserializer.c" -yy83: - yych = *++YYCURSOR; - if (yych <= '/') goto yy18; - if (yych >= ':') goto yy18; -yy84: - ++YYCURSOR; - if (YYLIMIT <= YYCURSOR) YYFILL(1); - yych = *YYCURSOR; - if (yych <= '/') goto yy18; - if (yych <= '9') goto yy84; - if (yych != ';') goto yy18; - ++YYCURSOR; -#line 648 "ext/standard/var_unserializer.re" - { - zend_long id; - - *p = YYCURSOR; - if (!var_hash) return 0; - - id = parse_uiv(start + 2) - 1; - if (id == -1 || (rval_ref = var_access(var_hash, id)) == NULL) { - return 0; - } - - if (rval_ref == rval) { - return 0; - } - - if (Z_ISUNDEF_P(rval_ref) || (Z_ISREF_P(rval_ref) && Z_ISUNDEF_P(Z_REFVAL_P(rval_ref)))) { - ZVAL_UNDEF(rval); - return 1; - } - - ZVAL_COPY(rval, rval_ref); - - return 1; -} -#line 1353 "ext/standard/var_unserializer.c" -yy88: - yych = *++YYCURSOR; - if (yych <= '/') goto yy18; - if (yych >= ':') goto yy18; -yy89: - ++YYCURSOR; - if (YYLIMIT <= YYCURSOR) YYFILL(1); - yych = *YYCURSOR; - if (yych <= '/') goto yy18; - if (yych <= '9') goto yy89; - if (yych != ';') goto yy18; - ++YYCURSOR; -#line 622 "ext/standard/var_unserializer.re" - { - zend_long id; - - *p = YYCURSOR; - if (!var_hash) return 0; - - id = parse_uiv(start + 2) - 1; - if (id == -1 || (rval_ref = var_access(var_hash, id)) == NULL) { - return 0; - } - - zval_ptr_dtor(rval); - if (Z_ISUNDEF_P(rval_ref) || (Z_ISREF_P(rval_ref) && Z_ISUNDEF_P(Z_REFVAL_P(rval_ref)))) { - ZVAL_UNDEF(rval); - return 1; - } - if (Z_ISREF_P(rval_ref)) { - ZVAL_COPY(rval, rval_ref); - } else { - ZVAL_NEW_REF(rval_ref, rval_ref); - ZVAL_COPY(rval, rval_ref); - } - - return 1; -} -#line 1392 "ext/standard/var_unserializer.c" +#line 1422 "ext/standard/var_unserializer.c" } -#line 1009 "ext/standard/var_unserializer.re" +#line 1013 "ext/standard/var_unserializer.re" return 0; diff --git a/ext/standard/var_unserializer.re b/ext/standard/var_unserializer.re index 6b5f3ef4e0..bfb879dfac 100644 --- a/ext/standard/var_unserializer.re +++ b/ext/standard/var_unserializer.re @@ -549,6 +549,10 @@ static inline int object_common2(UNSERIALIZE_PARAMETER, zend_long elements) && zend_hash_str_exists(&Z_OBJCE_P(rval)->function_table, "__wakeup", sizeof("__wakeup")-1); ht = Z_OBJPROP_P(rval); + if (elements >= HT_MAX_SIZE - zend_hash_num_elements(ht)) { + return 0; + } + zend_hash_extend(ht, zend_hash_num_elements(ht) + elements, (ht->u.flags & HASH_FLAG_PACKED)); if (!process_nested_data(UNSERIALIZE_PASSTHRU, ht, elements, 1)) { if (has_wakeup) { @@ -811,7 +815,7 @@ use_double: *p = YYCURSOR; if (!var_hash) return 0; - if (elements < 0) { + if (elements < 0 || elements >= HT_MAX_SIZE) { return 0; } @@ -840,7 +844,7 @@ use_double: if (!var_hash) return 0; elements = object_common1(UNSERIALIZE_PASSTHRU, ZEND_STANDARD_CLASS_DEF_PTR); - if (elements < 0) { + if (elements < 0 || elements >= HT_MAX_SIZE) { return 0; } return object_common2(UNSERIALIZE_PASSTHRU, elements); |