diff options
| author | Andrey Hristov <andrey@php.net> | 2007-01-12 20:26:35 +0000 |
|---|---|---|
| committer | Andrey Hristov <andrey@php.net> | 2007-01-12 20:26:35 +0000 |
| commit | f483a60f3abbd2ec920726ed52779ebd31d928ce (patch) | |
| tree | bd62c1acee3abfab503d8f761b2e89a24fcbef29 /ext/mysqli/mysqli_api.c | |
| parent | 83e658d12089e7b9ea6c2b2b2fe9f1f86710bc68 (diff) | |
| download | php-git-f483a60f3abbd2ec920726ed52779ebd31d928ce.tar.gz | |
add a sticky note
Diffstat (limited to 'ext/mysqli/mysqli_api.c')
| -rw-r--r-- | ext/mysqli/mysqli_api.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/ext/mysqli/mysqli_api.c b/ext/mysqli/mysqli_api.c index b73c4081bc..18afcc5b62 100644 --- a/ext/mysqli/mysqli_api.c +++ b/ext/mysqli/mysqli_api.c @@ -686,6 +686,11 @@ PHP_FUNCTION(mysqli_stmt_fetch) if (!ret) { #endif for (i = 0; i < stmt->result.var_cnt; i++) { + /* + QQ: Isn't it quite better to call zval_dtor(). What if the user has + assigned a resource, or an array to the bound variable? We are going + to leak probably. zval_dtor() will handle also Unicode/Non-unicode mode. + */ /* Even if the string is of length zero there is one byte alloced so efree() in all cases */ if (Z_TYPE_P(stmt->result.vars[i]) == IS_STRING) { efree(stmt->result.vars[i]->value.str.val); |