diff options
| author | Nikita Popov <nikita.ppv@gmail.com> | 2020-11-30 16:45:48 +0100 |
|---|---|---|
| committer | Nikita Popov <nikita.ppv@gmail.com> | 2021-02-11 21:46:13 +0100 |
| commit | b10416a652d26577a22fe0b183b2258b20c8bb86 (patch) | |
| tree | 3b79102286b2307575f487bf97d572ffc292631d /ext/sockets | |
| parent | f06895488a5fabd27ac4c2e66a9d311f14d8594e (diff) | |
| download | php-git-b10416a652d26577a22fe0b183b2258b20c8bb86.tar.gz | |
Deprecate passing null to non-nullable arg of internal function
This deprecates passing null to non-nullable scale arguments of
internal functions, with the eventual goal of making the behavior
consistent with userland functions, where null is never accepted
for non-nullable arguments.
This change is expected to cause quite a lot of fallout. In most
cases, calling code should be adjusted to avoid passing null. In
some cases, PHP should be adjusted to make some function arguments
nullable. I have already fixed a number of functions before landing
this, but feel free to file a bug if you encounter a function that
doesn't accept null, but probably should. (The rule of thumb for
this to be applicable is that the function must have special behavior
for 0 or "", which is distinct from the natural behavior of the
parameter.)
RFC: https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg
Closes GH-6475.
Diffstat (limited to 'ext/sockets')
| -rw-r--r-- | ext/sockets/tests/socket_create_pair-wrongparams-win32.phpt | 4 | ||||
| -rw-r--r-- | ext/sockets/tests/socket_create_pair-wrongparams.phpt | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/ext/sockets/tests/socket_create_pair-wrongparams-win32.phpt b/ext/sockets/tests/socket_create_pair-wrongparams-win32.phpt index ff4dd5de06..399563fde1 100644 --- a/ext/sockets/tests/socket_create_pair-wrongparams-win32.phpt +++ b/ext/sockets/tests/socket_create_pair-wrongparams-win32.phpt @@ -11,10 +11,10 @@ if (!extension_loaded('sockets')) { --FILE-- <?php -var_dump(socket_create_pair(AF_INET, null, null, $sockets)); +var_dump(socket_create_pair(AF_INET, 0, 0, $sockets)); try { - var_dump(socket_create_pair(31337, null, null, $sockets)); + var_dump(socket_create_pair(31337, 0, 0, $sockets)); } catch (\ValueError $e) { echo $e->getMessage() . \PHP_EOL; } diff --git a/ext/sockets/tests/socket_create_pair-wrongparams.phpt b/ext/sockets/tests/socket_create_pair-wrongparams.phpt index 57111c83f1..d6a4d4562d 100644 --- a/ext/sockets/tests/socket_create_pair-wrongparams.phpt +++ b/ext/sockets/tests/socket_create_pair-wrongparams.phpt @@ -11,10 +11,10 @@ if (!extension_loaded('sockets')) { --FILE-- <?php -var_dump(socket_create_pair(AF_INET, null, null, $sockets)); +var_dump(socket_create_pair(AF_INET, 0, 0, $sockets)); try { - var_dump(socket_create_pair(31337, null, null, $sockets)); + var_dump(socket_create_pair(31337, 0, 0, $sockets)); } catch (\ValueError $e) { echo $e->getMessage() . \PHP_EOL; } |