SplFixedArray is Aggregate, not Iterable

One strange feature of SplFixedArray was that it could not be used in nested foreach
loops. If one did so, the inner loop would overwrite the iteration state of the outer
loop.

To illustrate:

    $spl = SplFixedArray::fromArray([0, 1]);
    foreach ($spl as $a) {
      foreach ($spl as $b) {
        echo "$a $b";
      }
    }

Would only print two lines:

    0 0
    0 1

Use the new InternalIterator feature which was introduced in ff19ec2df3 to convert
SplFixedArray to an Aggregate rather than Iterable. As a bonus, we get to trim down
some ugly code! Yay!

1 files changed, 2 insertions, 15 deletions

diff --git a/ext/spl/spl_fixedarray.stub.php b/ext/spl/spl_fixedarray.stub.php
index 553de5c2fa..b169dfdeac 100755
--- a/ext/spl/spl_fixedarray.stub.php
+++ b/ext/spl/spl_fixedarray.stub.php
@@ -2,7 +2,7 @@
 
 /** @generate-function-entries */
 
-class SplFixedArray implements Iterator, ArrayAccess, Countable
+class SplFixedArray implements IteratorAggregate, ArrayAccess, Countable
 {
     public function __construct(int $size = 0) {}
 
@@ -48,18 +48,5 @@ class SplFixedArray implements Iterator, ArrayAccess, Countable
      */
     public function offsetUnset($index) {}
 
-    /** @return void */
-    public function rewind() {}
-
-    /** @return mixed */
-    public function current() {}
-
-    /** @return int */
-    public function key() {}
-
-    /** @return void */
-    public function next() {}
-
-    /** @return bool */
-    public function valid() {}
+    public function getIterator(): Iterator {}
 }