diff options
| author | Derick Rethans <derick@php.net> | 2007-09-06 13:27:31 +0000 |
|---|---|---|
| committer | Derick Rethans <derick@php.net> | 2007-09-06 13:27:31 +0000 |
| commit | 8d57a9f689d3053fe62a6438053c4d67eb701877 (patch) | |
| tree | 69632f86e9f2b8e0480e4bebc0381f307fb1cd19 /ext/standard/basic_functions.c | |
| parent | 87632ef25c0ef51483b410921deedc246f80ff2d (diff) | |
| download | php-git-8d57a9f689d3053fe62a6438053c4d67eb701877.tar.gz | |
- Add a comment why not ~0 or -1.
Diffstat (limited to 'ext/standard/basic_functions.c')
| -rw-r--r-- | ext/standard/basic_functions.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/ext/standard/basic_functions.c b/ext/standard/basic_functions.c index 01beaf8fb2..45106f1cb1 100644 --- a/ext/standard/basic_functions.c +++ b/ext/standard/basic_functions.c @@ -4280,7 +4280,8 @@ PHP_FUNCTION(ip2long) if (addr_len == 0 || (ip = inet_addr(addr)) == INADDR_NONE) { /* the only special case when we should return -1 ourselves, - * because inet_addr() considers it wrong. + * because inet_addr() considers it wrong. We return 0xFFFFFFFF and + * not -1 or ~0 because of 32/64bit issues. */ if (addr_len == sizeof("255.255.255.255") - 1 && !memcmp(addr, "255.255.255.255", sizeof("255.255.255.255") - 1)) { |
