Deprecate passing null to non-nullable arg of internal function

This deprecates passing null to non-nullable scale arguments of
internal functions, with the eventual goal of making the behavior
consistent with userland functions, where null is never accepted
for non-nullable arguments.

This change is expected to cause quite a lot of fallout. In most
cases, calling code should be adjusted to avoid passing null. In
some cases, PHP should be adjusted to make some function arguments
nullable. I have already fixed a number of functions before landing
this, but feel free to file a bug if you encounter a function that
doesn't accept null, but probably should. (The rule of thumb for
this to be applicable is that the function must have special behavior
for 0 or "", which is distinct from the natural behavior of the
parameter.)

RFC: https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg

Closes GH-6475.

1 files changed, 1 insertions, 28 deletions

diff --git a/ext/standard/tests/math/fmod_basic.phpt b/ext/standard/tests/math/fmod_basic.phpt
index 731b76adab..84cd27125c 100644
--- a/ext/standard/tests/math/fmod_basic.phpt
+++ b/ext/standard/tests/math/fmod_basic.phpt
@@ -13,7 +13,6 @@ $values1 = array(234,
                 "234",
                 "234.5",
                 "23.45e1",
-                null,
                 true,
                 false);
 
@@ -26,7 +25,6 @@ $values2 = array(2,
                 "2",
                 "2.3",
                 "2.3e1",
-                null,
                 true,
                 false);
 for ($i = 0; $i < count($values1); $i++) {
@@ -49,7 +47,6 @@ float(0)
 float(0)
 float(1.700000000000018)
 float(4)
-float(NAN)
 float(0)
 float(NAN)
 
@@ -63,7 +60,6 @@ float(-0)
 float(-0)
 float(-1.700000000000018)
 float(-4)
-float(NAN)
 float(-0)
 float(NAN)
 
@@ -77,7 +73,6 @@ float(0.5)
 float(0.5)
 float(2.200000000000018)
 float(4.5)
-float(NAN)
 float(0.5)
 float(NAN)
 
@@ -91,7 +86,6 @@ float(-0.5)
 float(-0.5)
 float(-2.200000000000018)
 float(-4.5)
-float(NAN)
 float(-0.5)
 float(NAN)
 
@@ -105,7 +99,6 @@ float(0)
 float(0)
 float(1.700000000000018)
 float(4)
-float(NAN)
 float(0)
 float(NAN)
 
@@ -119,7 +112,6 @@ float(0)
 float(0)
 float(1.700000000000018)
 float(4)
-float(NAN)
 float(0)
 float(NAN)
 
@@ -133,7 +125,6 @@ float(0)
 float(0)
 float(1.700000000000018)
 float(4)
-float(NAN)
 float(0)
 float(NAN)
 
@@ -147,7 +138,6 @@ float(0.5)
 float(0.5)
 float(2.200000000000018)
 float(4.5)
-float(NAN)
 float(0.5)
 float(NAN)
 
@@ -161,25 +151,10 @@ float(0.5)
 float(0.5)
 float(2.200000000000018)
 float(4.5)
-float(NAN)
 float(0.5)
 float(NAN)
 
 iteration 9
-float(0)
-float(0)
-float(0)
-float(0)
-float(0)
-float(0)
-float(0)
-float(0)
-float(0)
-float(NAN)
-float(0)
-float(NAN)
-
-iteration 10
 float(1)
 float(1)
 float(1)
@@ -189,11 +164,10 @@ float(1)
 float(1)
 float(1)
 float(1)
-float(NAN)
 float(0)
 float(NAN)
 
-iteration 11
+iteration 10
 float(0)
 float(0)
 float(0)
@@ -203,6 +177,5 @@ float(0)
 float(0)
 float(0)
 float(0)
-float(NAN)
 float(0)
 float(NAN)