summaryrefslogtreecommitdiff
path: root/sapi/apache2handler/php_functions.c
diff options
context:
space:
mode:
authorNikita Popov <nikita.ppv@gmail.com>2019-02-21 16:59:30 +0100
committerNikita Popov <nikita.ppv@gmail.com>2019-02-22 10:50:56 +0100
commit914c1ec1d4e65ac599762388df5a22696e2f968b (patch)
tree868efb1f7bef97318c7da07f390d4ce9cb5ad9e6 /sapi/apache2handler/php_functions.c
parent427ebce6295b296c1f18f6bd927bf3cd295be815 (diff)
downloadphp-git-914c1ec1d4e65ac599762388df5a22696e2f968b.tar.gz
Stricter validation for popen mode argument on Windows
Context: The ext/standard/tests/file/popen_pclose_error-win32.phpt test often fails under parallel testing, because the "is not recognized as an internal or external command" message doesn't actually have a guaranteed position in the output. While looking into this, I noticed that this test on Windows tests something very different (invalid comand) than on Linux (invalid mode). Here I'm adjusting the Windows popen implementation so it immediately fails on a `rw` mode, just like it does on Linux.
Diffstat (limited to 'sapi/apache2handler/php_functions.c')
0 files changed, 0 insertions, 0 deletions