| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
Closes GH-6610.
|
|
|
|
| |
Closes GH-6617
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Historically, the _ex variants separated the zval first, if a
conversion was necessary. This distinction no longer makes sense
since PHP 7.
The only difference that was still left is that _ex checked whether
the type is the same first, but the usage of these macros did not
actually distinguish on whether such an inlined check is valuable
or not in a given context.
Also drop the unused convert_to_explicit_type macros.
|
|
|
|
| |
Closes GH-6547
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
This includes begin(), commit(), rollBack(), and inTransaction()
|
|
|
|
|
| |
Rather than storing char* + size_t, use a zend_string*. Also
avoid various copies of the query string.
|
|
|
|
|
|
|
|
|
| |
Add a get_gc method that can be implemented by drivers, which can
be used to add additional zvals to the GC buffer.
Implement GC support for PDO SQLite callbacks in particular.
Closes GH-6262.
|
|
|
|
|
|
|
|
|
|
| |
bind parameters
Added new flags that allow skipping param_evt(s) that are not used by drivers,
in a backwards and forward compatible manner. Updated the pgsql, mysql, sqlite
and oci drivers to properly use the new flags. I've left out pdo_dblib, which
doesn't have a param_hook, and pdo_firebird, which seems to be using
PARAM_EVT_NORMALIZE in a wrong context (param type vs event type).
|
|\
| |
| |
| |
| | |
* PHP-7.4:
Fix #64705 errorInfo property of PDOException is null when PDO::__construct() fails
|
| |\
| | |
| | |
| | |
| | | |
* PHP-7.3:
Fix #64705 errorInfo property of PDOException is null when PDO::__construct() fails
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
PDO::__construct() fails
PDO driver constructors are throwing PdoException without setting
errorInfo, so create a new reusable function that throws exceptions
for PDO and will also set the errorInfo. Use this function in
pdo_mysql, pdo_sqlite, and pdo_pgsql.
|
| | |
| | |
| | |
| | | |
Putting these under a dummy PDO_SQLite_Ext class.
|
| | | |
|
| | |
| | |
| | |
| | | |
Closes GH-5066 As a first step, let's capitalize their initial letter when it is applicable.
|
| | |
| | |
| | |
| | |
| | | |
As ZPP now throws, it makes no sense to specify an explicit return
value.
|
|/ /
| |
| |
| | |
Closes GH-4732.
|
| | |
|
| |
| |
| |
| |
| |
| | |
This function has been deprecated, with the recommendation that
the count should be explicitly tracked in the aggregate context,
if it is needed.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
RFC: https://wiki.php.net/rfc/tostring_exceptions
And convert some object to string conversion related recoverable
fatal errors into Error exceptions.
Improve exception safety of internal code performing string
conversions.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly used by Vim and Emacs editors
yet with recent changes the once working definitions don't work
anymore in Vim without custom plugins or additional configuration.
Neither are these settings synced across the PHP code base.
A simpler and better approach is EditorConfig and fixing code
using some code style fixing tools in the future instead.
This patch also removes the so called modelines for Vim. Modelines
allow Vim editor specifically to set some editor configuration such as
syntax highlighting, indentation style and tab width to be set in the
first line or the last 5 lines per file basis. Since the php test
files have syntax highlighting already set in most editors properly and
EditorConfig takes care of the indentation settings, this patch removes
these as well for the Vim 6.0 and newer versions.
With the removal of local variables for certain editors such as
Emacs and Vim, the footer is also probably not needed anymore when
creating extensions using ext_skel.php script.
Additionally, Vim modelines for setting php syntax and some editor
settings has been removed from some *.phpt files. All these are
mostly not relevant for phpt files neither work properly in the
middle of the file.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
While both source and destination buffers have the same size (6 bytes),
and this is unlikely to change in the future, we nonetheless fix the
illogical `strncpy` size.
Based on a pull request provided by Cristian Rodríguez.
|
| | |
|
| | |
|
|/
|
|
|
|
|
|
|
| |
It is possible to pass flags when opening an SQLite database. For
Sqlite < 3.5.0 these are ignored, since `sqlite3_open` doesn't support
flags. Neither a warning or notice is raised in this case, nor is this
behavior documented in the PHP manual. Instead of fixing it either
way, we lift the requirement to SQLite 3.5.0 (released on 2007-09-04)
instead of the former SQLite 3.3.9 (released on 2007-01-04).
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
user who changed it.
In Git this functionality is different and can be done with Git attribute
ident. These need to be defined manually for each file in the
.gitattributes file and are afterwards replaced with 40-character
hexadecimal blob object name which is based only on the particular file
contents.
This patch simplifies handling of $Id$ keywords by removing them since
they are not used anymore.
|
|
|
|
| |
where we sure about string persistence.
|
| |
|
| |
|
|
|
|
|
|
| |
Prohibit direct update of GC_REFCOUNT(), GC_SET_REFCOUNT(), GC_ADDREF() and GC_DELREF() shoukf be instead.
Added mactros to validate reference-counting (disabled for now).
These macros are going to be used to eliminate race-condintions during reference-counting on data shared between threads.
|
| |
|
| |
|
|
|
|
|
| |
Mostly the callback name is only used to report an error. Try to
avoid calculating it if no error occurred.
|
| |
|
|\ |
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
The sqlite3 docs suggest always using prepare_v2 and the close_v2
could potentially help with an fd leak we have been seeing
|
| | |
|
|/ |
|
| |
|
|
|
|
| |
but is never used.
|
| |
|