diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2019-08-04 14:05:34 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2019-08-04 14:05:34 -0400 |
| commit | e0f5048851ff88a53630a0c121a1cd15f6a2f1cd (patch) | |
| tree | c0737bb205b2b080b69a23068b9dffa70b98a76b /contrib/jsonb_plperl/jsonb_plperl.c | |
| parent | 803466b6ffaa2e5b94d8ce4d7fffa8185f2a0184 (diff) | |
| download | postgresql-e0f5048851ff88a53630a0c121a1cd15f6a2f1cd.tar.gz | |
Fix handling of "undef" in contrib/jsonb_plperl.
Perl has multiple internal representations of "undef", and just
testing for SvTYPE(x) == SVt_NULL doesn't recognize all of them,
leading to "cannot transform this Perl type to jsonb" errors.
Use the approved test SvOK() instead.
Report and patch by Ivan Panchenko. Back-patch to v11 where
this module was added.
Discussion: https://postgr.es/m/1564783533.324795401@f193.i.mail.ru
Diffstat (limited to 'contrib/jsonb_plperl/jsonb_plperl.c')
| -rw-r--r-- | contrib/jsonb_plperl/jsonb_plperl.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/contrib/jsonb_plperl/jsonb_plperl.c b/contrib/jsonb_plperl/jsonb_plperl.c index b26723a958..04b04df953 100644 --- a/contrib/jsonb_plperl/jsonb_plperl.c +++ b/contrib/jsonb_plperl/jsonb_plperl.c @@ -189,12 +189,12 @@ SV_to_JsonbValue(SV *in, JsonbParseState **jsonb_state, bool is_elem) case SVt_PVHV: return HV_to_JsonbValue((HV *) in, jsonb_state); - case SVt_NULL: - out.type = jbvNull; - break; - default: - if (SvUOK(in)) + if (!SvOK(in)) + { + out.type = jbvNull; + } + else if (SvUOK(in)) { /* * If UV is >=64 bits, we have no better way to make this |