diff options
| author | Bruce Momjian <bruce@momjian.us> | 2002-03-05 05:30:40 +0000 |
|---|---|---|
| committer | Bruce Momjian <bruce@momjian.us> | 2002-03-05 05:30:40 +0000 |
| commit | 276fc7ce829404627075ebf8ed5ee3039923eb2b (patch) | |
| tree | b0b280d11c9029b5ef7da2db030f71efc2178230 /src/backend/access/gist/gistget.c | |
| parent | 33766e680d815b66e108f9b6d536f1ff059c954b (diff) | |
| download | postgresql-276fc7ce829404627075ebf8ed5ee3039923eb2b.tar.gz | |
I was digging through the GiST code, and figured I'd fix up some of the
"bad smell" in that code. Stuff like function parameters that aren't
used, typos in the comments, comparison between signed and unsigned
ints, etc.
Attached is a pretty trivial patch; it compiles, but beyond that
completely untested. Unless anyone sees any problems, please apply for
7.3.
Neil Conway
Diffstat (limited to 'src/backend/access/gist/gistget.c')
| -rw-r--r-- | src/backend/access/gist/gistget.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/backend/access/gist/gistget.c b/src/backend/access/gist/gistget.c index ed92258e62..826644288a 100644 --- a/src/backend/access/gist/gistget.c +++ b/src/backend/access/gist/gistget.c @@ -8,7 +8,7 @@ * Portions Copyright (c) 1994, Regents of the University of California * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/access/gist/gistget.c,v 1.31 2001/10/25 05:49:20 momjian Exp $ + * $Header: /cvsroot/pgsql/src/backend/access/gist/gistget.c,v 1.32 2002/03/05 05:30:31 momjian Exp $ * *------------------------------------------------------------------------- */ @@ -24,7 +24,7 @@ static RetrieveIndexResult gistscancache(IndexScanDesc s, ScanDirection dir); static RetrieveIndexResult gistfirst(IndexScanDesc s, ScanDirection dir); static RetrieveIndexResult gistnext(IndexScanDesc s, ScanDirection dir); static ItemPointer gistheapptr(Relation r, ItemPointer itemp); -static bool gistindex_keytest(IndexTuple tuple, TupleDesc tupdesc, +static bool gistindex_keytest(IndexTuple tuple, int scanKeySize, ScanKey key, GISTSTATE *giststate, Relation r, Page p, OffsetNumber offset); @@ -219,7 +219,6 @@ gistnext(IndexScanDesc s, ScanDirection dir) /* Similar to index_keytest, but decompresses the key in the IndexTuple */ static bool gistindex_keytest(IndexTuple tuple, - TupleDesc tupdesc, int scanKeySize, ScanKey key, GISTSTATE *giststate, @@ -314,7 +313,6 @@ gistfindnext(IndexScanDesc s, Page p, OffsetNumber n, ScanDirection dir) { it = (IndexTuple) PageGetItem(p, PageGetItemId(p, n)); if (gistindex_keytest(it, - RelationGetDescr(s->relation), s->numberOfKeys, s->keyData, giststate, s->relation, p, n)) break; |