diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2005-11-06 19:29:01 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2005-11-06 19:29:01 +0000 |
| commit | 766dc45d9f133aaa12d952052e1e512dbf3f5ec0 (patch) | |
| tree | 9ab560a2274467ac31af307471129d4cdbee272e /src/backend/access/nbtree/nbtinsert.c | |
| parent | 18691d8ee3e4729948f6348d25ee1e4bba2379fe (diff) | |
| download | postgresql-766dc45d9f133aaa12d952052e1e512dbf3f5ec0.tar.gz | |
Add defenses to btree and hash index AMs to do simple sanity checks
on every index page they read; in particular to catch the case of an
all-zero page, which PageHeaderIsValid allows to pass. It turns out
hash already had this idea, but it was just Assert()ing things rather
than doing a straight error check, and the Asserts were partially
redundant with PageHeaderIsValid anyway. Per recent failure example
from Jim Nasby. (gist still needs the same treatment.)
Diffstat (limited to 'src/backend/access/nbtree/nbtinsert.c')
| -rw-r--r-- | src/backend/access/nbtree/nbtinsert.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/access/nbtree/nbtinsert.c b/src/backend/access/nbtree/nbtinsert.c index 33c7612aac..3ef40a5cb6 100644 --- a/src/backend/access/nbtree/nbtinsert.c +++ b/src/backend/access/nbtree/nbtinsert.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/access/nbtree/nbtinsert.c,v 1.127 2005/10/15 02:49:09 momjian Exp $ + * $PostgreSQL: pgsql/src/backend/access/nbtree/nbtinsert.c,v 1.128 2005/11/06 19:29:00 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -672,7 +672,7 @@ _bt_split(Relation rel, Buffer buf, OffsetNumber firstright, rightpage = BufferGetPage(rbuf); _bt_pageinit(leftpage, BufferGetPageSize(buf)); - _bt_pageinit(rightpage, BufferGetPageSize(rbuf)); + /* rightpage was already initialized by _bt_getbuf */ /* init btree private data */ oopaque = (BTPageOpaque) PageGetSpecialPointer(origpage); |