diff options
| author | Neil Conway <neilc@samurai.com> | 2004-11-14 02:04:14 +0000 |
|---|---|---|
| committer | Neil Conway <neilc@samurai.com> | 2004-11-14 02:04:14 +0000 |
| commit | a236dd9536bd4624b259759e08cb2b8d4585ab0f (patch) | |
| tree | 193c4b8d5962fb3c30fbc657c4650b67723d93b1 /src/backend/commands/analyze.c | |
| parent | 1c5125adf320316de46705a2f25548de2d20bbcc (diff) | |
| download | postgresql-a236dd9536bd4624b259759e08cb2b8d4585ab0f.tar.gz | |
There is no need for ReadBuffer() call sites to check that the returned
buffer is valid, as ReadBuffer() will elog on error. Most of the call
sites of ReadBuffer() got this right, but this patch fixes those call
sites that did not.
Diffstat (limited to 'src/backend/commands/analyze.c')
| -rw-r--r-- | src/backend/commands/analyze.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/backend/commands/analyze.c b/src/backend/commands/analyze.c index 872edc4298..3157d1dfd6 100644 --- a/src/backend/commands/analyze.c +++ b/src/backend/commands/analyze.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/commands/analyze.c,v 1.78 2004/10/26 16:05:03 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/commands/analyze.c,v 1.79 2004/11/14 02:04:13 neilc Exp $ * *------------------------------------------------------------------------- */ @@ -811,8 +811,6 @@ acquire_sample_rows(Relation onerel, HeapTuple *rows, int targrows, * tuples. */ targbuffer = ReadBuffer(onerel, targblock); - if (!BufferIsValid(targbuffer)) - elog(ERROR, "ReadBuffer failed"); LockBuffer(targbuffer, BUFFER_LOCK_SHARE); targpage = BufferGetPage(targbuffer); maxoffset = PageGetMaxOffsetNumber(targpage); |