diff options
| author | David Rowley <drowley@postgresql.org> | 2021-04-01 13:33:23 +1300 |
|---|---|---|
| committer | David Rowley <drowley@postgresql.org> | 2021-04-01 13:33:23 +1300 |
| commit | 28b3e3905c982c42fb10ee800e6f881e9742c89d (patch) | |
| tree | 5368a84ddedf0c0da61fc9ec73ea148658821f0b /src/backend/nodes/copyfuncs.c | |
| parent | b6002a796dc0bfe721db5eaa54ba9d24fd9fd416 (diff) | |
| download | postgresql-28b3e3905c982c42fb10ee800e6f881e9742c89d.tar.gz | |
Revert b6002a796
This removes "Add Result Cache executor node". It seems that something
weird is going on with the tracking of cache hits and misses as
highlighted by many buildfarm animals. It's not yet clear what the
problem is as other parts of the plan indicate that the cache did work
correctly, it's just the hits and misses that were being reported as 0.
This is especially a bad time to have the buildfarm so broken, so
reverting before too many more animals go red.
Discussion: https://postgr.es/m/CAApHDvq_hydhfovm4=izgWs+C5HqEeRScjMbOgbpC-jRAeK3Yw@mail.gmail.com
Diffstat (limited to 'src/backend/nodes/copyfuncs.c')
| -rw-r--r-- | src/backend/nodes/copyfuncs.c | 31 |
1 files changed, 0 insertions, 31 deletions
diff --git a/src/backend/nodes/copyfuncs.c b/src/backend/nodes/copyfuncs.c index ad729d10a8..44c7fce20a 100644 --- a/src/backend/nodes/copyfuncs.c +++ b/src/backend/nodes/copyfuncs.c @@ -949,33 +949,6 @@ _copyMaterial(const Material *from) /* - * _copyResultCache - */ -static ResultCache * -_copyResultCache(const ResultCache *from) -{ - ResultCache *newnode = makeNode(ResultCache); - - /* - * copy node superclass fields - */ - CopyPlanFields((const Plan *) from, (Plan *) newnode); - - /* - * copy remainder of node - */ - COPY_SCALAR_FIELD(numKeys); - COPY_POINTER_FIELD(hashOperators, sizeof(Oid) * from->numKeys); - COPY_POINTER_FIELD(collations, sizeof(Oid) * from->numKeys); - COPY_NODE_FIELD(param_exprs); - COPY_SCALAR_FIELD(singlerow); - COPY_SCALAR_FIELD(est_entries); - - return newnode; -} - - -/* * CopySortFields * * This function copies the fields of the Sort node. It is used by @@ -2367,7 +2340,6 @@ _copyRestrictInfo(const RestrictInfo *from) COPY_SCALAR_FIELD(right_bucketsize); COPY_SCALAR_FIELD(left_mcvfreq); COPY_SCALAR_FIELD(right_mcvfreq); - COPY_SCALAR_FIELD(hasheqoperator); return newnode; } @@ -5052,9 +5024,6 @@ copyObjectImpl(const void *from) case T_Material: retval = _copyMaterial(from); break; - case T_ResultCache: - retval = _copyResultCache(from); - break; case T_Sort: retval = _copySort(from); break; |