Revert b6002a796

This removes "Add Result Cache executor node".  It seems that something
weird is going on with the tracking of cache hits and misses as
highlighted by many buildfarm animals.  It's not yet clear what the
problem is as other parts of the plan indicate that the cache did work
correctly, it's just the hits and misses that were being reported as 0.

This is especially a bad time to have the buildfarm so broken, so
reverting before too many more animals go red.

Discussion: https://postgr.es/m/CAApHDvq_hydhfovm4=izgWs+C5HqEeRScjMbOgbpC-jRAeK3Yw@mail.gmail.com

1 files changed, 0 insertions, 37 deletions

diff --git a/src/backend/nodes/outfuncs.c b/src/backend/nodes/outfuncs.c
index fa8f65fbc5..785465d8c4 100644
--- a/src/backend/nodes/outfuncs.c
+++ b/src/backend/nodes/outfuncs.c
@@ -847,21 +847,6 @@ _outMaterial(StringInfo str, const Material *node)
 }
 
 static void
-_outResultCache(StringInfo str, const ResultCache *node)
-{
-	WRITE_NODE_TYPE("RESULTCACHE");
-
-	_outPlanInfo(str, (const Plan *) node);
-
-	WRITE_INT_FIELD(numKeys);
-	WRITE_OID_ARRAY(hashOperators, node->numKeys);
-	WRITE_OID_ARRAY(collations, node->numKeys);
-	WRITE_NODE_FIELD(param_exprs);
-	WRITE_BOOL_FIELD(singlerow);
-	WRITE_UINT_FIELD(est_entries);
-}
-
-static void
 _outSortInfo(StringInfo str, const Sort *node)
 {
 	_outPlanInfo(str, (const Plan *) node);
@@ -1936,21 +1921,6 @@ _outMaterialPath(StringInfo str, const MaterialPath *node)
 }
 
 static void
-_outResultCachePath(StringInfo str, const ResultCachePath *node)
-{
-	WRITE_NODE_TYPE("RESULTCACHEPATH");
-
-	_outPathInfo(str, (const Path *) node);
-
-	WRITE_NODE_FIELD(subpath);
-	WRITE_NODE_FIELD(hash_operators);
-	WRITE_NODE_FIELD(param_exprs);
-	WRITE_BOOL_FIELD(singlerow);
-	WRITE_FLOAT_FIELD(calls, "%.0f");
-	WRITE_UINT_FIELD(est_entries);
-}
-
-static void
 _outUniquePath(StringInfo str, const UniquePath *node)
 {
 	WRITE_NODE_TYPE("UNIQUEPATH");
@@ -2551,7 +2521,6 @@ _outRestrictInfo(StringInfo str, const RestrictInfo *node)
 	WRITE_NODE_FIELD(right_em);
 	WRITE_BOOL_FIELD(outer_is_left);
 	WRITE_OID_FIELD(hashjoinoperator);
-	WRITE_OID_FIELD(hasheqoperator);
 }
 
 static void
@@ -3938,9 +3907,6 @@ outNode(StringInfo str, const void *obj)
 			case T_Material:
 				_outMaterial(str, obj);
 				break;
-			case T_ResultCache:
-				_outResultCache(str, obj);
-				break;
 			case T_Sort:
 				_outSort(str, obj);
 				break;
@@ -4175,9 +4141,6 @@ outNode(StringInfo str, const void *obj)
 			case T_MaterialPath:
 				_outMaterialPath(str, obj);
 				break;
-			case T_ResultCachePath:
-				_outResultCachePath(str, obj);
-				break;
 			case T_UniquePath:
 				_outUniquePath(str, obj);
 				break;