diff options
| author | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2008-07-11 02:10:14 +0000 |
|---|---|---|
| committer | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2008-07-11 02:10:14 +0000 |
| commit | 110147653aebe8eba9a42559e3737ac0d48d107f (patch) | |
| tree | fa1ed0f6f69effad15b366709ffb84169f5fd85e /src/backend/storage/ipc/procarray.c | |
| parent | 0c2914d4cb56923933b5a710d9ce84c275065594 (diff) | |
| download | postgresql-110147653aebe8eba9a42559e3737ac0d48d107f.tar.gz | |
Make sure we only try to free snapshots that have been passed through
CopySnapshot, per Neil Conway. Also add a comment about the assumption in
GetSnapshotData that the argument is statically allocated.
Also, fix some more typos in comments in snapmgr.c.
Diffstat (limited to 'src/backend/storage/ipc/procarray.c')
| -rw-r--r-- | src/backend/storage/ipc/procarray.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/backend/storage/ipc/procarray.c b/src/backend/storage/ipc/procarray.c index 62a17003c1..0286809d1c 100644 --- a/src/backend/storage/ipc/procarray.c +++ b/src/backend/storage/ipc/procarray.c @@ -23,7 +23,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/storage/ipc/procarray.c,v 1.44 2008/05/12 20:02:00 alvherre Exp $ + * $PostgreSQL: pgsql/src/backend/storage/ipc/procarray.c,v 1.45 2008/07/11 02:10:13 alvherre Exp $ * *------------------------------------------------------------------------- */ @@ -666,6 +666,9 @@ GetOldestXmin(bool allDbs, bool ignoreVacuum) * RecentGlobalXmin: the global xmin (oldest TransactionXmin across all * running transactions, except those running LAZY VACUUM). This is * the same computation done by GetOldestXmin(true, true). + * + * Note: this function should probably not be called with an argument that's + * not statically allocated (see xip allocation below). */ Snapshot GetSnapshotData(Snapshot snapshot) |