diff options
| author | Michael Paquier <michael@paquier.xyz> | 2021-09-08 09:44:04 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2021-09-08 09:44:04 +0900 |
| commit | fd0625c7a9c679c0c1e896014b8f49a489c3a245 (patch) | |
| tree | cacddafcd64a4f00d87f6551b29937f9e5ced415 /src/backend/utils | |
| parent | d6c916f020e291b45563d4e76a649e9364cb6f2d (diff) | |
| download | postgresql-fd0625c7a9c679c0c1e896014b8f49a489c3a245.tar.gz | |
Clean up some code using "(expr) ? true : false"
All the code paths simplified here were already using a boolean or used
an expression that led to zero or one, making the extra bits
unnecessary.
Author: Justin Pryzby
Reviewed-by: Tom Lane, Michael Paquier, Peter Smith
Discussion: https://postgr.es/m/20210428182936.GE27406@telsasoft.com
Diffstat (limited to 'src/backend/utils')
| -rw-r--r-- | src/backend/utils/adt/bool.c | 2 | ||||
| -rw-r--r-- | src/backend/utils/adt/ruleutils.c | 4 | ||||
| -rw-r--r-- | src/backend/utils/adt/tsquery_gist.c | 2 | ||||
| -rw-r--r-- | src/backend/utils/adt/tsquery_util.c | 2 | ||||
| -rw-r--r-- | src/backend/utils/fmgr/dfmgr.c | 2 |
5 files changed, 6 insertions, 6 deletions
diff --git a/src/backend/utils/adt/bool.c b/src/backend/utils/adt/bool.c index fe11d1ae94..cd98f84270 100644 --- a/src/backend/utils/adt/bool.c +++ b/src/backend/utils/adt/bool.c @@ -184,7 +184,7 @@ boolrecv(PG_FUNCTION_ARGS) int ext; ext = pq_getmsgbyte(buf); - PG_RETURN_BOOL((ext != 0) ? true : false); + PG_RETURN_BOOL(ext != 0); } /* diff --git a/src/backend/utils/adt/ruleutils.c b/src/backend/utils/adt/ruleutils.c index 8ff4e5dc07..1fb0b7b098 100644 --- a/src/backend/utils/adt/ruleutils.c +++ b/src/backend/utils/adt/ruleutils.c @@ -8005,14 +8005,14 @@ isSimpleNode(Node *node, Node *parentNode, int prettyFlags) * appears simple since . has top precedence, unless parent is * T_FieldSelect itself! */ - return (IsA(parentNode, FieldSelect) ? false : true); + return !IsA(parentNode, FieldSelect); case T_FieldStore: /* * treat like FieldSelect (probably doesn't matter) */ - return (IsA(parentNode, FieldStore) ? false : true); + return !IsA(parentNode, FieldStore); case T_CoerceToDomain: /* maybe simple, check args */ diff --git a/src/backend/utils/adt/tsquery_gist.c b/src/backend/utils/adt/tsquery_gist.c index 14d7343afa..906a686914 100644 --- a/src/backend/utils/adt/tsquery_gist.c +++ b/src/backend/utils/adt/tsquery_gist.c @@ -109,7 +109,7 @@ gtsquery_same(PG_FUNCTION_ARGS) TSQuerySign b = PG_GETARG_TSQUERYSIGN(1); bool *result = (bool *) PG_GETARG_POINTER(2); - *result = (a == b) ? true : false; + *result = (a == b); PG_RETURN_POINTER(result); } diff --git a/src/backend/utils/adt/tsquery_util.c b/src/backend/utils/adt/tsquery_util.c index 7f936427b5..b3dd4f4be0 100644 --- a/src/backend/utils/adt/tsquery_util.c +++ b/src/backend/utils/adt/tsquery_util.c @@ -186,7 +186,7 @@ QTNEq(QTNode *a, QTNode *b) if (!(sign == a->sign && sign == b->sign)) return false; - return (QTNodeCompare(a, b) == 0) ? true : false; + return (QTNodeCompare(a, b) == 0); } /* diff --git a/src/backend/utils/fmgr/dfmgr.c b/src/backend/utils/fmgr/dfmgr.c index e8c6cdde97..96fd9d2268 100644 --- a/src/backend/utils/fmgr/dfmgr.c +++ b/src/backend/utils/fmgr/dfmgr.c @@ -458,7 +458,7 @@ file_exists(const char *name) AssertArg(name != NULL); if (stat(name, &st) == 0) - return S_ISDIR(st.st_mode) ? false : true; + return !S_ISDIR(st.st_mode); else if (!(errno == ENOENT || errno == ENOTDIR || errno == EACCES)) ereport(ERROR, (errcode_for_file_access(), |