diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2005-11-06 19:29:01 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2005-11-06 19:29:01 +0000 |
| commit | 766dc45d9f133aaa12d952052e1e512dbf3f5ec0 (patch) | |
| tree | 9ab560a2274467ac31af307471129d4cdbee272e /src/include/access/hash.h | |
| parent | 18691d8ee3e4729948f6348d25ee1e4bba2379fe (diff) | |
| download | postgresql-766dc45d9f133aaa12d952052e1e512dbf3f5ec0.tar.gz | |
Add defenses to btree and hash index AMs to do simple sanity checks
on every index page they read; in particular to catch the case of an
all-zero page, which PageHeaderIsValid allows to pass. It turns out
hash already had this idea, but it was just Assert()ing things rather
than doing a straight error check, and the Asserts were partially
redundant with PageHeaderIsValid anyway. Per recent failure example
from Jim Nasby. (gist still needs the same treatment.)
Diffstat (limited to 'src/include/access/hash.h')
| -rw-r--r-- | src/include/access/hash.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/include/access/hash.h b/src/include/access/hash.h index b433524f7c..f56b609dcf 100644 --- a/src/include/access/hash.h +++ b/src/include/access/hash.h @@ -7,7 +7,7 @@ * Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * - * $PostgreSQL: pgsql/src/include/access/hash.h,v 1.63 2005/10/15 02:49:42 momjian Exp $ + * $PostgreSQL: pgsql/src/include/access/hash.h,v 1.64 2005/11/06 19:29:01 tgl Exp $ * * NOTES * modeled after Margo Seltzer's hash implementation for unix. @@ -310,7 +310,7 @@ extern uint32 _hash_datum2hashkey(Relation rel, Datum key); extern Bucket _hash_hashkey2bucket(uint32 hashkey, uint32 maxbucket, uint32 highmask, uint32 lowmask); extern uint32 _hash_log2(uint32 num); -extern void _hash_checkpage(Relation rel, Page page, int flags); +extern void _hash_checkpage(Relation rel, Buffer buf, int flags); /* hash.c */ extern void hash_redo(XLogRecPtr lsn, XLogRecord *record); |