diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2001-06-01 02:41:36 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2001-06-01 02:41:36 +0000 |
| commit | 0b370ea7c81228339da5a447057dbf5f874e0197 (patch) | |
| tree | 125c8590975f212a7caec6667f95f28d772bb928 /src/include/commands/trigger.h | |
| parent | a1d9d096f0f36afcdd4ca69afb41cd645b9834d2 (diff) | |
| download | postgresql-0b370ea7c81228339da5a447057dbf5f874e0197.tar.gz | |
Clean up some minor problems exposed by further thought about Panon's bug
report on old-style functions invoked by RI triggers. We had a number of
other places that were being sloppy about which memory context FmgrInfo
subsidiary data will be allocated in. Turns out none of them actually
cause a problem in 7.1, but this is for arcane reasons such as the fact
that old-style triggers aren't supported anyway. To avoid getting burnt
later, I've restructured the trigger support so that we don't keep trigger
FmgrInfo structs in relcache memory. Some other related cleanups too:
it's not really necessary to call fmgr_info at all while setting up
the index support info in relcache entries, because those ScanKeyEntry
structs are never used to invoke the functions. This should speed up
relcache initialization a tiny bit.
Diffstat (limited to 'src/include/commands/trigger.h')
| -rw-r--r-- | src/include/commands/trigger.h | 28 |
1 files changed, 19 insertions, 9 deletions
diff --git a/src/include/commands/trigger.h b/src/include/commands/trigger.h index 46c4a49764..ddb9a327db 100644 --- a/src/include/commands/trigger.h +++ b/src/include/commands/trigger.h @@ -6,7 +6,7 @@ * Portions Copyright (c) 1996-2001, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * - * $Id: trigger.h,v 1.26 2001/03/22 04:00:43 momjian Exp $ + * $Id: trigger.h,v 1.27 2001/06/01 02:41:36 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -90,15 +90,25 @@ extern void FreeTriggerDesc(TriggerDesc *trigdesc); extern bool equalTriggerDescs(TriggerDesc *trigdesc1, TriggerDesc *trigdesc2); extern HeapTuple ExecBRInsertTriggers(EState *estate, - Relation rel, HeapTuple tuple); + ResultRelInfo *relinfo, + HeapTuple trigtuple); extern void ExecARInsertTriggers(EState *estate, - Relation rel, HeapTuple tuple); -extern bool ExecBRDeleteTriggers(EState *estate, ItemPointer tupleid); -extern void ExecARDeleteTriggers(EState *estate, ItemPointer tupleid); -extern HeapTuple ExecBRUpdateTriggers(EState *estate, ItemPointer tupleid, - HeapTuple tuple); -extern void ExecARUpdateTriggers(EState *estate, ItemPointer tupleid, - HeapTuple tuple); + ResultRelInfo *relinfo, + HeapTuple trigtuple); +extern bool ExecBRDeleteTriggers(EState *estate, + ResultRelInfo *relinfo, + ItemPointer tupleid); +extern void ExecARDeleteTriggers(EState *estate, + ResultRelInfo *relinfo, + ItemPointer tupleid); +extern HeapTuple ExecBRUpdateTriggers(EState *estate, + ResultRelInfo *relinfo, + ItemPointer tupleid, + HeapTuple newtuple); +extern void ExecARUpdateTriggers(EState *estate, + ResultRelInfo *relinfo, + ItemPointer tupleid, + HeapTuple newtuple); /* ---------- |