diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2009-02-25 03:30:38 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2009-02-25 03:30:38 +0000 |
| commit | e549722a8b2fcc5b2ad9a9bd53948466ea5dae26 (patch) | |
| tree | a55ae57bb515b353f70a8321a0751ed5aca40044 /src/include/optimizer | |
| parent | 7380b6384b5a0b25fa7dfa7447dbf95ff1c4b8da (diff) | |
| download | postgresql-e549722a8b2fcc5b2ad9a9bd53948466ea5dae26.tar.gz | |
Get rid of the rather fuzzily defined FlattenedSubLink node type in favor of
making pull_up_sublinks() construct a full-blown JoinExpr tree representation
of IN/EXISTS SubLinks that it is able to convert to semi or anti joins.
This makes pull_up_sublinks() a shade more complex, but the gain in semantic
clarity is worth it. I still have more to do in this area to address the
previously-discussed problems, but this commit in itself fixes at least one
bug in HEAD, as shown by added regression test case.
Diffstat (limited to 'src/include/optimizer')
| -rw-r--r-- | src/include/optimizer/subselect.h | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/src/include/optimizer/subselect.h b/src/include/optimizer/subselect.h index 54965a5fe7..a318853596 100644 --- a/src/include/optimizer/subselect.h +++ b/src/include/optimizer/subselect.h @@ -5,7 +5,7 @@ * Portions Copyright (c) 1996-2009, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * - * $PostgreSQL: pgsql/src/include/optimizer/subselect.h,v 1.35 2009/01/01 17:24:00 momjian Exp $ + * $PostgreSQL: pgsql/src/include/optimizer/subselect.h,v 1.36 2009/02/25 03:30:38 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -16,13 +16,13 @@ #include "nodes/relation.h" extern void SS_process_ctes(PlannerInfo *root); -extern bool convert_ANY_sublink_to_join(PlannerInfo *root, SubLink *sublink, - Relids available_rels, - Node **new_qual, List **fromlist); -extern bool convert_EXISTS_sublink_to_join(PlannerInfo *root, SubLink *sublink, - bool under_not, - Relids available_rels, - Node **new_qual, List **fromlist); +extern JoinExpr *convert_ANY_sublink_to_join(PlannerInfo *root, + SubLink *sublink, + Relids available_rels); +extern JoinExpr *convert_EXISTS_sublink_to_join(PlannerInfo *root, + SubLink *sublink, + bool under_not, + Relids available_rels); extern Node *SS_replace_correlation_vars(PlannerInfo *root, Node *expr); extern Node *SS_process_sublinks(PlannerInfo *root, Node *expr, bool isQual); extern void SS_finalize_plan(PlannerInfo *root, Plan *plan, |