diff options
| author | Amit Kapila <akapila@postgresql.org> | 2020-07-13 08:06:05 +0530 |
|---|---|---|
| committer | Amit Kapila <akapila@postgresql.org> | 2020-07-13 08:53:23 +0530 |
| commit | d973747281caece520236e93d255c654cc613ec9 (patch) | |
| tree | 5f80b648a1a3490b47bde42d0a06d9fbb84524eb /src/include/replication | |
| parent | 5bfe6a3c485d3259f59fa2d2e1d34dea1a3baeba (diff) | |
| download | postgresql-d973747281caece520236e93d255c654cc613ec9.tar.gz | |
Revert "Track statistics for spilling of changes from ReorderBuffer".
The stats with this commit was available only for WALSenders, however,
users might want to see for backends doing logical decoding via SQL API.
Then, users might want to reset and access these stats across server
restart which was not possible with the current patch.
List of commits reverted:
caa3c4242c Don't call elog() while holding spinlock.
e641b2a995 Doc: Update the documentation for spilled transaction
statistics.
5883f5fe27 Fix unportable printf format introduced in commit 9290ad198.
9290ad198b Track statistics for spilling of changes from ReorderBuffer.
Additionaly, remove the release notes entry for this feature.
Backpatch-through: 13, where it was introduced
Discussion: https://postgr.es/m/CA+fd4k5_pPAYRTDrO2PbtTOe0eHQpBvuqmCr8ic39uTNmR49Eg@mail.gmail.com
Diffstat (limited to 'src/include/replication')
| -rw-r--r-- | src/include/replication/reorderbuffer.h | 11 | ||||
| -rw-r--r-- | src/include/replication/walsender_private.h | 5 |
2 files changed, 0 insertions, 16 deletions
diff --git a/src/include/replication/reorderbuffer.h b/src/include/replication/reorderbuffer.h index 626ecf4dc9..019bd382de 100644 --- a/src/include/replication/reorderbuffer.h +++ b/src/include/replication/reorderbuffer.h @@ -413,17 +413,6 @@ struct ReorderBuffer /* memory accounting */ Size size; - - /* - * Statistics about transactions spilled to disk. - * - * A single transaction may be spilled repeatedly, which is why we keep - * two different counters. For spilling, the transaction counter includes - * both toplevel transactions and subtransactions. - */ - int64 spillCount; /* spill-to-disk invocation counter */ - int64 spillTxns; /* number of transactions spilled to disk */ - int64 spillBytes; /* amount of data spilled to disk */ }; diff --git a/src/include/replication/walsender_private.h b/src/include/replication/walsender_private.h index 734acec2a4..509856c057 100644 --- a/src/include/replication/walsender_private.h +++ b/src/include/replication/walsender_private.h @@ -78,11 +78,6 @@ typedef struct WalSnd * Timestamp of the last message received from standby. */ TimestampTz replyTime; - - /* Statistics for transactions spilled to disk. */ - int64 spillTxns; - int64 spillCount; - int64 spillBytes; } WalSnd; extern WalSnd *MyWalSnd; |