diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2008-11-30 20:51:25 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2008-11-30 20:51:25 +0000 |
| commit | c1f3073333d01987ac9c3e5f6c197b9e2afc3ba9 (patch) | |
| tree | b70ddff5404c442ec13a5c182346984d4300f6da /src/include/utils | |
| parent | 3f936aacc057e4b391ab953fea2ffb689a12a8bc (diff) | |
| download | postgresql-c1f3073333d01987ac9c3e5f6c197b9e2afc3ba9.tar.gz | |
Clean up the API for DestReceiver objects by eliminating the assumption
that a Portal is a useful and sufficient additional argument for
CreateDestReceiver --- it just isn't, in most cases. Instead formalize
the approach of passing any needed parameters to the receiver separately.
One unexpected benefit of this change is that we can declare typedef Portal
in a less surprising location.
This patch is just code rearrangement and doesn't change any functionality.
I'll tackle the HOLD-cursor-vs-toast problem in a follow-on patch.
Diffstat (limited to 'src/include/utils')
| -rw-r--r-- | src/include/utils/portal.h | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/include/utils/portal.h b/src/include/utils/portal.h index c420d4d71e..c6ccbf493e 100644 --- a/src/include/utils/portal.h +++ b/src/include/utils/portal.h @@ -39,7 +39,7 @@ * Portions Copyright (c) 1996-2008, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * - * $PostgreSQL: pgsql/src/include/utils/portal.h,v 1.79 2008/07/18 20:26:06 tgl Exp $ + * $PostgreSQL: pgsql/src/include/utils/portal.h,v 1.80 2008/11/30 20:51:25 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -102,10 +102,7 @@ typedef enum PortalStatus PORTAL_FAILED /* portal got error (can't re-run it) */ } PortalStatus; -/* - * Note: typedef Portal is declared in tcop/dest.h as - * typedef struct PortalData *Portal; - */ +typedef struct PortalData *Portal; typedef struct PortalData { |