summaryrefslogtreecommitdiff
path: root/src/test/isolation/README
diff options
context:
space:
mode:
authorNoah Misch <noah@leadboat.com>2022-07-01 18:27:50 -0700
committerNoah Misch <noah@leadboat.com>2022-07-01 18:27:50 -0700
commitc99c67fc43f8659517310c62e8a2637d56d0e449 (patch)
tree2766c91317762538ab6facd0be43128e53b4680a /src/test/isolation/README
parent4f4c72c2dc06e944950305b0c1f48071ff49e263 (diff)
downloadpostgresql-c99c67fc43f8659517310c62e8a2637d56d0e449.tar.gz
Replace PGISOLATIONTIMEOUT with 2 * PG_TEST_TIMEOUT_DEFAULT.
Now that the more-generic variable exists, use it. Discussion: https://postgr.es/m/20220219024136.GA3670392@rfd.leadboat.com
Diffstat (limited to 'src/test/isolation/README')
-rw-r--r--src/test/isolation/README15
1 files changed, 8 insertions, 7 deletions
diff --git a/src/test/isolation/README b/src/test/isolation/README
index 8457a5689f..5818ca5003 100644
--- a/src/test/isolation/README
+++ b/src/test/isolation/README
@@ -47,10 +47,10 @@ pg_isolation_regress is a tool similar to pg_regress, but instead of using
psql to execute a test, it uses isolationtester. It accepts all the same
command-line arguments as pg_regress.
-By default, isolationtester will wait at most 300 seconds (5 minutes)
+By default, isolationtester will wait at most 360 seconds (6 minutes)
for any one test step to complete. If you need to adjust this, set
-the environment variable PGISOLATIONTIMEOUT to the desired timeout
-in seconds.
+the environment variable PG_TEST_TIMEOUT_DEFAULT to half the desired
+timeout in seconds.
Test specification
@@ -138,10 +138,11 @@ Each step may contain commands that block until further action has been taken
deadlock). A test that uses this ability must manually specify valid
permutations, i.e. those that would not expect a blocked session to execute a
command. If a test fails to follow that rule, isolationtester will cancel it
-after PGISOLATIONTIMEOUT seconds. If the cancel doesn't work, isolationtester
-will exit uncleanly after a total of twice PGISOLATIONTIMEOUT. Testing
-invalid permutations should be avoided because they can make the isolation
-tests take a very long time to run, and they serve no useful testing purpose.
+after 2 * PG_TEST_TIMEOUT_DEFAULT seconds. If the cancel doesn't work,
+isolationtester will exit uncleanly after a total of 4 *
+PG_TEST_TIMEOUT_DEFAULT. Testing invalid permutations should be avoided
+because they can make the isolation tests take a very long time to run, and
+they serve no useful testing purpose.
Note that isolationtester recognizes that a command has blocked by looking
to see if it is shown as waiting in the pg_locks view; therefore, only