diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2015-09-05 11:58:20 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2015-09-05 11:58:33 -0400 |
| commit | 0426f349effb6bde2061f3398a71db7180c97dd9 (patch) | |
| tree | 741fcee27d57266182690fefd31721b8d6546b1e /src/test/regress/expected/rangefuncs.out | |
| parent | c80b5f66c6faff085e312492be0aa50754e99eb9 (diff) | |
| download | postgresql-0426f349effb6bde2061f3398a71db7180c97dd9.tar.gz | |
Rearrange the handling of error context reports.
Remove the code in plpgsql that suppressed the innermost line of CONTEXT
for messages emitted by RAISE commands. That was never more than a quick
backwards-compatibility hack, and it's pretty silly in cases where the
RAISE is nested in several levels of function. What's more, it violated
our design theory that verbosity of error reports should be controlled
on the client side not the server side.
To alleviate the resulting noise increase, introduce a feature in libpq
and psql whereby the CONTEXT field of messages can be suppressed, either
always or only for non-error messages. Printing CONTEXT for errors only
is now their default behavior.
The actual code changes here are pretty small, but the effects on the
regression test outputs are widespread. I had to edit some of the
alternative expected outputs by hand; hopefully the buildfarm will soon
find anything I fat-fingered.
In passing, fix up (again) the output line counts in psql's various
help displays. Add some commentary about how to verify them.
Pavel Stehule, reviewed by Petr Jelínek, Jeevan Chalke, and others
Diffstat (limited to 'src/test/regress/expected/rangefuncs.out')
| -rw-r--r-- | src/test/regress/expected/rangefuncs.out | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/test/regress/expected/rangefuncs.out b/src/test/regress/expected/rangefuncs.out index 6dabe503cc..00ef421054 100644 --- a/src/test/regress/expected/rangefuncs.out +++ b/src/test/regress/expected/rangefuncs.out @@ -1704,9 +1704,7 @@ create trigger tnoticetrigger after insert on tt for each row execute procedure noticetrigger(); select insert_tt2('foolme','barme') limit 1; NOTICE: noticetrigger 11 foolme -CONTEXT: SQL function "insert_tt2" statement 1 NOTICE: noticetrigger 12 barme -CONTEXT: SQL function "insert_tt2" statement 1 insert_tt2 ------------ 11 @@ -1735,9 +1733,7 @@ create rule insert_tt_rule as on insert to tt do also insert into tt_log values(new.*); select insert_tt2('foollog','barlog') limit 1; NOTICE: noticetrigger 13 foollog -CONTEXT: SQL function "insert_tt2" statement 1 NOTICE: noticetrigger 14 barlog -CONTEXT: SQL function "insert_tt2" statement 1 insert_tt2 ------------ 13 |