Backend support for autocommit removed, per recent discussions. The

only remnant of this failed experiment is that the server will take
SET AUTOCOMMIT TO ON.  Still TODO: provide some client-side autocommit
logic in libpq.

6 files changed, 16 insertions, 11 deletions

diff --git a/src/test/regress/sql/alter_table.sql b/src/test/regress/sql/alter_table.sql
index c97b72cabe..f28b4f246c 100644
--- a/src/test/regress/sql/alter_table.sql
+++ b/src/test/regress/sql/alter_table.sql
@@ -717,7 +717,6 @@ copy test("........pg.dropped.1........") to stdout;
 copy test from stdin;
 10	11	12
 \.
-SET autocommit TO 'on';
 select * from test;
 copy test from stdin;
 21	22
diff --git a/src/test/regress/sql/copy2.sql b/src/test/regress/sql/copy2.sql
index b036cb1b7f..72c52dba11 100644
--- a/src/test/regress/sql/copy2.sql
+++ b/src/test/regress/sql/copy2.sql
@@ -71,7 +71,6 @@ COPY x from stdin;
 2002	232	40	50	60	70	80
 \.
 
-SET autocommit TO 'on';
 -- various COPY options: delimiters, oids, NULL string
 COPY x (b, c, d, e) from stdin with oids delimiter ',' null 'x';
 500000,x,45,80,90
diff --git a/src/test/regress/sql/domain.sql b/src/test/regress/sql/domain.sql
index 00a38f449c..32295ff186 100644
--- a/src/test/regress/sql/domain.sql
+++ b/src/test/regress/sql/domain.sql
@@ -41,8 +41,6 @@ COPY basictest (testvarchar) FROM stdin; -- fail
 notsoshorttext
 \.
 
-SET autocommit TO 'on';
-
 COPY basictest (testvarchar) FROM stdin;
 short
 \.
@@ -106,8 +104,6 @@ COPY nulltest FROM stdin; --fail
 a	b	\N	d	\N
 \.
 
-SET autocommit TO 'on';
-
 -- Last row is bad
 COPY nulltest FROM stdin;
 a	b	c	\N	c
diff --git a/src/test/regress/sql/oidjoins.sql b/src/test/regress/sql/oidjoins.sql
index a9df8f666a..5e8323bc11 100644
--- a/src/test/regress/sql/oidjoins.sql
+++ b/src/test/regress/sql/oidjoins.sql
@@ -53,6 +53,10 @@ SELECT	ctid, ambulkdelete
 FROM	pg_catalog.pg_am fk 
 WHERE	ambulkdelete != 0 AND 
 	NOT EXISTS(SELECT 1 FROM pg_catalog.pg_proc pk WHERE pk.oid = fk.ambulkdelete);
+SELECT	ctid, amvacuumcleanup 
+FROM	pg_catalog.pg_am fk 
+WHERE	amvacuumcleanup != 0 AND 
+	NOT EXISTS(SELECT 1 FROM pg_catalog.pg_proc pk WHERE pk.oid = fk.amvacuumcleanup);
 SELECT	ctid, amcostestimate 
 FROM	pg_catalog.pg_am fk 
 WHERE	amcostestimate != 0 AND 
@@ -114,6 +118,14 @@ FROM	pg_catalog.pg_class fk
 WHERE	reltoastidxid != 0 AND 
 	NOT EXISTS(SELECT 1 FROM pg_catalog.pg_class pk WHERE pk.oid = fk.reltoastidxid);
 SELECT	ctid, connamespace 
+FROM	pg_catalog.pg_constraint fk 
+WHERE	connamespace != 0 AND 
+	NOT EXISTS(SELECT 1 FROM pg_catalog.pg_namespace pk WHERE pk.oid = fk.connamespace);
+SELECT	ctid, contypid 
+FROM	pg_catalog.pg_constraint fk 
+WHERE	contypid != 0 AND 
+	NOT EXISTS(SELECT 1 FROM pg_catalog.pg_type pk WHERE pk.oid = fk.contypid);
+SELECT	ctid, connamespace 
 FROM	pg_catalog.pg_conversion fk 
 WHERE	connamespace != 0 AND 
 	NOT EXISTS(SELECT 1 FROM pg_catalog.pg_namespace pk WHERE pk.oid = fk.connamespace);
@@ -277,3 +289,7 @@ SELECT	ctid, typsend
 FROM	pg_catalog.pg_type fk 
 WHERE	typsend != 0 AND 
 	NOT EXISTS(SELECT 1 FROM pg_catalog.pg_proc pk WHERE pk.oid = fk.typsend);
+SELECT	ctid, typbasetype 
+FROM	pg_catalog.pg_type fk 
+WHERE	typbasetype != 0 AND 
+	NOT EXISTS(SELECT 1 FROM pg_catalog.pg_type pk WHERE pk.oid = fk.typbasetype);
diff --git a/src/test/regress/sql/privileges.sql b/src/test/regress/sql/privileges.sql
index d7076d2575..d3e9b54303 100644
--- a/src/test/regress/sql/privileges.sql
+++ b/src/test/regress/sql/privileges.sql
@@ -147,7 +147,6 @@ SELECT * FROM atestv2; -- fail (even though regressuser2 can access underlying a
 
 -- switch to superuser
 \c -
-SET autocommit TO 'on';
 
 REVOKE ALL PRIVILEGES ON LANGUAGE sql FROM PUBLIC;
 GRANT USAGE ON LANGUAGE sql TO regressuser1; -- ok
@@ -184,7 +183,6 @@ SELECT testfunc1(5); -- ok
 DROP FUNCTION testfunc1(int); -- fail
 
 \c -
-SET autocommit TO 'on';
 
 DROP FUNCTION testfunc1(int); -- ok
 -- restore to sanity
@@ -203,7 +201,6 @@ select has_table_privilege(1,'rule');
 
 -- superuser
 \c -
-SET autocommit TO 'on';
 
 select has_table_privilege(current_user,'pg_shadow','select');
 select has_table_privilege(current_user,'pg_shadow','insert');
@@ -323,7 +320,6 @@ SELECT has_table_privilege('regressuser1', 'atest4', 'SELECT WITH GRANT OPTION')
 -- clean up
 
 \c regression
-SET autocommit TO 'on';
 
 DROP FUNCTION testfunc2(int);
 DROP FUNCTION testfunc4(boolean);
diff --git a/src/test/regress/sql/temp.sql b/src/test/regress/sql/temp.sql
index 5ebd13c83c..397d00bfd9 100644
--- a/src/test/regress/sql/temp.sql
+++ b/src/test/regress/sql/temp.sql
@@ -48,7 +48,6 @@ DROP TABLE temptest;
 CREATE TEMP TABLE temptest(col int);
 
 \c regression
-SET autocommit TO 'on';
 
 SELECT * FROM temptest;